(Translated by https://www.hiragana.jp/)
♟ cmassaro
Page MenuHomePhabricator

cmassaro (Cory Massaro)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 5 2021, 4:31 PM (200 w, 2 d)
Availability
Available
LDAP User
Cory Massaro
MediaWiki User
CMassaro (WMF) [ Global Accounts ]

Recent Activity

Today

cmassaro claimed T379098: Pre-Cache ZIDs the First Time We Try to Resolve; Have Other Resolve Calls Wait on a Promise.
Thu, Nov 7, 7:58 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), Abstract Wikipedia Fix-It tasks, function-orchestrator

Yesterday

cmassaro updated subscribers of T378763: Mocha "after" block doesn't run if a test times out.

I'm puzzled as to why this is happening. Maybe the use of a global hook defined using a separate file in mocha.opts is the answer? https://futurestud.io/tutorials/mocha-global-setup-and-teardown-before-after

Wed, Nov 6, 5:58 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), Abstract Wikipedia Fix-It tasks, function-evaluator

Tue, Nov 5

cmassaro created T379098: Pre-Cache ZIDs the First Time We Try to Resolve; Have Other Resolve Calls Wait on a Promise.
Tue, Nov 5, 5:14 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro created T379088: Application Security Review Request : Wikifunctions Rust-Based Function Evaluator.
Tue, Nov 5, 3:59 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator, secscrum, Security, Application Security Reviews
cmassaro placed T373992: The generic Type of a Typed list is not always evaluated in Expected results? up for grabs.
Tue, Nov 5, 11:59 AM · Abstract Wikipedia team
cmassaro moved T378557: Write Rust Functions to Parse JSON from a File and to Stringify Parsed JSON from Essential work to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.
Tue, Nov 5, 1:20 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro claimed T378557: Write Rust Functions to Parse JSON from a File and to Stringify Parsed JSON.
Tue, Nov 5, 1:19 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator

Thu, Oct 31

cmassaro created T378763: Mocha "after" block doesn't run if a test times out.
Thu, Oct 31, 8:04 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), Abstract Wikipedia Fix-It tasks, function-evaluator

Wed, Oct 30

cmassaro added a subtask for T377020: Begin Porting the Evaluator Code to Go or Rust: T378601: Create a Trivial Unit Test Using Rust.
Wed, Oct 30, 1:53 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, function-evaluator, function-orchestrator
cmassaro added a parent task for T378601: Create a Trivial Unit Test Using Rust: T377020: Begin Porting the Evaluator Code to Go or Rust.
Wed, Oct 30, 1:53 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro created T378601: Create a Trivial Unit Test Using Rust.
Wed, Oct 30, 1:53 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro added a parent task for T378557: Write Rust Functions to Parse JSON from a File and to Stringify Parsed JSON: T377020: Begin Porting the Evaluator Code to Go or Rust.
Wed, Oct 30, 1:52 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro added a subtask for T377020: Begin Porting the Evaluator Code to Go or Rust: T378557: Write Rust Functions to Parse JSON from a File and to Stringify Parsed JSON.
Wed, Oct 30, 1:52 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, function-evaluator, function-orchestrator
cmassaro added a subtask for T377020: Begin Porting the Evaluator Code to Go or Rust: T378558: Write Rust Functions to Recognize Evaluator-Specific Regexes.
Wed, Oct 30, 1:52 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, function-evaluator, function-orchestrator
cmassaro added a parent task for T378558: Write Rust Functions to Recognize Evaluator-Specific Regexes: T377020: Begin Porting the Evaluator Code to Go or Rust.
Wed, Oct 30, 1:52 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro created T378558: Write Rust Functions to Recognize Evaluator-Specific Regexes.
Wed, Oct 30, 1:51 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro created T378557: Write Rust Functions to Parse JSON from a File and to Stringify Parsed JSON.
Wed, Oct 30, 1:50 AM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator

Mon, Oct 28

cmassaro updated the task description for T378381: [Spike] Explore algebraic Types support and how we could help users write more powerful functions with it.
Mon, Oct 28, 4:50 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, WikiLambda
cmassaro added a subtask for T376662: [25Q2] Iterate the Wikidata integration, and plan its and the Type system's evolution: T378381: [Spike] Explore algebraic Types support and how we could help users write more powerful functions with it.
Mon, Oct 28, 4:50 PM · Epic, Abstract Wikipedia team (25Q2 (Oct–Dec))
cmassaro added a parent task for T378381: [Spike] Explore algebraic Types support and how we could help users write more powerful functions with it: T376662: [25Q2] Iterate the Wikidata integration, and plan its and the Type system's evolution.
Mon, Oct 28, 4:50 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, WikiLambda
cmassaro claimed T378381: [Spike] Explore algebraic Types support and how we could help users write more powerful functions with it.
Mon, Oct 28, 4:50 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, WikiLambda
cmassaro created T378381: [Spike] Explore algebraic Types support and how we could help users write more powerful functions with it.
Mon, Oct 28, 4:50 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, WikiLambda

Tue, Oct 22

cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

Hmm, ignore the above. I realized my mistake. The set of rules I'm now running (instead of deny /** w is

Tue, Oct 22, 11:25 PM · serviceops
cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

Okay, I've managed to get your example running by replacing

Tue, Oct 22, 4:13 PM · serviceops

Mon, Oct 21

cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

In Rust, something similar happens with ld.so.cache. With the profile enforced:

Mon, Oct 21, 2:30 PM · serviceops
cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

Hmm, complain mode didn't change anything.

Mon, Oct 21, 2:24 PM · serviceops
cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

To debug apparmor profiles, an easy way is to add the complain flag. So, flags=(attach_disconnected) becomes flags=(complain) and the actions will be allowed and logged. That should some pretty specific hints as to what exactly would break in the "normal" (not fallbacks implemented in code to workaround failures) mode.

Mon, Oct 21, 10:20 AM · serviceops
cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

I tried using strace. Here's my new Dockerfile:

Mon, Oct 21, 10:15 AM · serviceops
cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

Interesting, yeah, I get a similar error with your source file and Dockerfile:

Mon, Oct 21, 9:59 AM · serviceops
cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

Hmm, weird! I am not on Mac (or are you saying you're on Mac?). I'll try running with your source file and Dockerfile.

Mon, Oct 21, 9:51 AM · serviceops

Fri, Oct 18

cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

Hmm. I get the same issue even when I add /dev/null rw to the profile.

Fri, Oct 18, 3:57 PM · serviceops
cmassaro added a comment to T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.

For Rust, I found this: openat(AT_FDCWD, "/dev/null", O_RDWR) = -1 EACCES (Permission denied) , so looks like it's read + write. Interestingly, this openat call only happens when AppArmor is enabled.

Fri, Oct 18, 1:42 PM · serviceops

Thu, Oct 17

cmassaro created T377468: Cannot Run Golang or Rust Binaries with Provided AppArmor Profile.
Thu, Oct 17, 2:56 PM · serviceops

Fri, Oct 11

cmassaro added a subtask for T377020: Begin Porting the Evaluator Code to Go or Rust: T377017: Decide Whether to Use Go or Rust.
Fri, Oct 11, 4:15 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, function-evaluator, function-orchestrator
cmassaro added a parent task for T377017: Decide Whether to Use Go or Rust: T377020: Begin Porting the Evaluator Code to Go or Rust.
Fri, Oct 11, 4:15 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator, function-orchestrator
cmassaro removed a subtask for T377017: Decide Whether to Use Go or Rust: T377020: Begin Porting the Evaluator Code to Go or Rust.
Fri, Oct 11, 4:15 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator, function-orchestrator
cmassaro removed a parent task for T377020: Begin Porting the Evaluator Code to Go or Rust: T377017: Decide Whether to Use Go or Rust.
Fri, Oct 11, 4:14 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, function-evaluator, function-orchestrator
cmassaro added a subtask for T376668: [25Q2] Service platform improvements: T377020: Begin Porting the Evaluator Code to Go or Rust.
Fri, Oct 11, 4:13 PM · Epic, Abstract Wikipedia team (25Q2 (Oct–Dec))
cmassaro added parent tasks for T377020: Begin Porting the Evaluator Code to Go or Rust: T377017: Decide Whether to Use Go or Rust, T376668: [25Q2] Service platform improvements.
Fri, Oct 11, 4:13 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, function-evaluator, function-orchestrator
cmassaro added a subtask for T377017: Decide Whether to Use Go or Rust: T377020: Begin Porting the Evaluator Code to Go or Rust.
Fri, Oct 11, 4:13 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator, function-orchestrator
cmassaro created T377020: Begin Porting the Evaluator Code to Go or Rust.
Fri, Oct 11, 4:13 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-schemata, function-evaluator, function-orchestrator
cmassaro claimed T377017: Decide Whether to Use Go or Rust.
Fri, Oct 11, 4:10 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator, function-orchestrator
cmassaro added a subtask for T376668: [25Q2] Service platform improvements: T377017: Decide Whether to Use Go or Rust.
Fri, Oct 11, 4:10 PM · Epic, Abstract Wikipedia team (25Q2 (Oct–Dec))
cmassaro added a parent task for T377017: Decide Whether to Use Go or Rust: T376668: [25Q2] Service platform improvements.
Fri, Oct 11, 4:10 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator, function-orchestrator
cmassaro created T377017: Decide Whether to Use Go or Rust.
Fri, Oct 11, 4:10 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator, function-orchestrator
cmassaro added a subtask for T376668: [25Q2] Service platform improvements: T377016: Get SRE's Feedback on Proposed Message-Passing Protocol for the New Evaluator.
Fri, Oct 11, 4:09 PM · Epic, Abstract Wikipedia team (25Q2 (Oct–Dec))
cmassaro added a parent task for T377016: Get SRE's Feedback on Proposed Message-Passing Protocol for the New Evaluator: T376668: [25Q2] Service platform improvements.
Fri, Oct 11, 4:09 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro created T377016: Get SRE's Feedback on Proposed Message-Passing Protocol for the New Evaluator.
Fri, Oct 11, 4:09 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator

Thu, Oct 10

cmassaro updated the task description for T376668: [25Q2] Service platform improvements.
Thu, Oct 10, 7:02 PM · Epic, Abstract Wikipedia team (25Q2 (Oct–Dec))

Oct 7 2024

cmassaro updated the task description for T376668: [25Q2] Service platform improvements.
Oct 7 2024, 11:38 PM · Epic, Abstract Wikipedia team (25Q2 (Oct–Dec))

Oct 4 2024

cmassaro created T376490: Fix Artifact Upload Error in Evaluator CI.
Oct 4 2024, 5:03 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), Abstract Wikipedia Fix-It tasks, function-evaluator

Sep 30 2024

cmassaro claimed T376053: Reduce Test Flake in Evaluator CI.
Sep 30 2024, 5:21 PM · Abstract Wikipedia Fix-It tasks, Patch-For-Review, Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro created T376053: Reduce Test Flake in Evaluator CI.
Sep 30 2024, 5:21 PM · Abstract Wikipedia Fix-It tasks, Patch-For-Review, Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator

Sep 24 2024

cmassaro claimed T375493: Add More Tests for Built-In Wikidata Item Equivalence.
Sep 24 2024, 12:15 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator
cmassaro created T375493: Add More Tests for Built-In Wikidata Item Equivalence.
Sep 24 2024, 12:15 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator

Sep 23 2024

cmassaro added a project to T375439: Future-Proof MSW Tests against Regressions due to MSW Version: Abstract Wikipedia Fix-It tasks.
Sep 23 2024, 8:20 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro created T375439: Future-Proof MSW Tests against Regressions due to MSW Version.
Sep 23 2024, 8:20 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team

Sep 20 2024

cmassaro added a comment to T373992: The generic Type of a Typed list is not always evaluated in Expected results?.

I see. There are a few things going on here.

Sep 20 2024, 4:05 PM · Abstract Wikipedia team
cmassaro added a comment to T373992: The generic Type of a Typed list is not always evaluated in Expected results?.

Hmm. I think the problem here is the use of Z17464, which is defined for references. The fully-resolved types that are returned are Z4/Types, not Z9/References. It seems to be that there should be a Type equality function for this case. Am I missing something?

Sep 20 2024, 3:11 PM · Abstract Wikipedia team

Sep 17 2024

cmassaro created T374985: Aggressively Rate-Limit Calls to Wikidata.
Sep 17 2024, 4:47 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-orchestrator

Sep 16 2024

cmassaro claimed T373992: The generic Type of a Typed list is not always evaluated in Expected results?.
Sep 16 2024, 12:45 PM · Abstract Wikipedia team

Sep 6 2024

cmassaro claimed T374257: Tests in test/features/v1/orchestrateTest.js Should Do Something.
Sep 6 2024, 3:37 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro created T374257: Tests in test/features/v1/orchestrateTest.js Should Do Something.
Sep 6 2024, 3:37 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator

Sep 5 2024

cmassaro added a comment to T369552: Analyze Performance Numbers and Discuss an Appropriate Spike.

New Numbers:

Sep 5 2024, 1:00 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda, function-schemata, function-evaluator, function-orchestrator

Aug 27 2024

cmassaro placed T368320: Renderers cannot render non-concrete values, e.g. values created through compositions or other function calls up for grabs.
Aug 27 2024, 3:32 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), WikiLambda Front-end
cmassaro moved T372938: Change evaluationDuration to Include Time Spent Queuing from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Aug 27 2024, 3:31 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro moved T372938: Change evaluationDuration to Include Time Spent Queuing from To triage to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Aug 27 2024, 3:31 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator

Aug 22 2024

cmassaro created T373110: Test Environment Variable Defaults and Configurability.
Aug 22 2024, 1:38 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a comment to T372938: Change evaluationDuration to Include Time Spent Queuing.

We do have other means of measuring this more granular time spans, but we don't expose them in the UI. It would be useful to exclude wait times when determining the fastest implementation.

Aug 22 2024, 1:35 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro added a comment to T372938: Change evaluationDuration to Include Time Spent Queuing.

We won't see them yet, no. Conceptually, there are three different interesting time spans in the evaluator:

Aug 22 2024, 1:35 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator

Aug 21 2024

cmassaro added a project to T373030: Create Abstraction for the Orchestrator in Order to Clean up Timeouts: Abstract Wikipedia Fix-It tasks.
Aug 21 2024, 3:21 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro updated the task description for T373030: Create Abstraction for the Orchestrator in Order to Clean up Timeouts.
Aug 21 2024, 3:08 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro created T373030: Create Abstraction for the Orchestrator in Order to Clean up Timeouts.
Aug 21 2024, 3:03 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team

Aug 20 2024

cmassaro claimed T372938: Change evaluationDuration to Include Time Spent Queuing.
Aug 20 2024, 8:19 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro created T372938: Change evaluationDuration to Include Time Spent Queuing.
Aug 20 2024, 8:18 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro claimed T372756: javascript - enabled wasmedge exceeds gas limit test is flaky.
Aug 20 2024, 2:16 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team

Aug 19 2024

cmassaro updated subscribers of T369552: Analyze Performance Numbers and Discuss an Appropriate Spike.

Thanks to @DMartin-WMF for the numbers:

Aug 19 2024, 7:18 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro created T372765: Increase Resources for function-evaluator CI.
Aug 19 2024, 1:24 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro added a parent task for T372721: Test What Happens When wasmedge Limits Are Very Low: T372756: javascript - enabled wasmedge exceeds gas limit test is flaky.
Aug 19 2024, 12:25 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a subtask for T372756: javascript - enabled wasmedge exceeds gas limit test is flaky: T372721: Test What Happens When wasmedge Limits Are Very Low.
Aug 19 2024, 12:25 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro created T372756: javascript - enabled wasmedge exceeds gas limit test is flaky.
Aug 19 2024, 12:25 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro placed T369173: Details of function calls sometimes in code up for grabs.
Aug 19 2024, 12:25 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-schemata, function-orchestrator, Wikifunctions
cmassaro created T372721: Test What Happens When wasmedge Limits Are Very Low.
Aug 19 2024, 2:09 AM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team

Aug 16 2024

cmassaro created T372665: Ensure that Executor.immaHeadOut Is Called Unconditionally.
Aug 16 2024, 6:56 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator

Aug 5 2024

cmassaro added a parent task for T371837: Performance Spike: Create a Pool of "Hot" Executor Processes to Eliminate wasmedge Startup Costs: T367933: [25Q1] Performance improvements.
Aug 5 2024, 4:57 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, function-evaluator
cmassaro added a subtask for T367933: [25Q1] Performance improvements: T371837: Performance Spike: Create a Pool of "Hot" Executor Processes to Eliminate wasmedge Startup Costs.
Aug 5 2024, 4:57 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro created T371837: Performance Spike: Create a Pool of "Hot" Executor Processes to Eliminate wasmedge Startup Costs.
Aug 5 2024, 4:55 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, function-evaluator
cmassaro renamed T371835: Test That function-schemata's Mutex Implementation Works in QuickJS from Test That Mutex Works in QuickJS to Test That function-schemata's Mutex Implementation Works in QuickJS.
Aug 5 2024, 4:44 PM · function-schemata, function-evaluator, Abstract Wikipedia team
cmassaro added a subtask for T361361: Protect Stream Access with a Mutex and Unique ID in Executors: T371835: Test That function-schemata's Mutex Implementation Works in QuickJS.
Aug 5 2024, 4:44 PM · Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, function-evaluator
cmassaro added a parent task for T371835: Test That function-schemata's Mutex Implementation Works in QuickJS: T361361: Protect Stream Access with a Mutex and Unique ID in Executors.
Aug 5 2024, 4:44 PM · function-schemata, function-evaluator, Abstract Wikipedia team
cmassaro created T371836: Consider Using Atomics to Improve Mutexes in Node.
Aug 5 2024, 4:41 PM · Abstract Wikipedia Fix-It tasks, function-schemata, function-evaluator, Abstract Wikipedia team
cmassaro created T371835: Test That function-schemata's Mutex Implementation Works in QuickJS.
Aug 5 2024, 4:39 PM · function-schemata, function-evaluator, Abstract Wikipedia team

Aug 1 2024

cmassaro added a comment to T371572: Test ALL Workflows with Potentially Naughty Escape Sequences.

The above MR demonstrates that the evaluator can handle these escape sequences, and that they are interpreted correctly when injected into code with eval/exec (if they were not interpreted correctly, the regex matches would not have been correct).

Aug 1 2024, 4:29 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a comment to T371561: bug: cannot save python implementation with regex.

@Harej : Just to be clear that it's the same issue, what happens if you double-escape all the Unicode sequences (e.g., \\u200e)?

Aug 1 2024, 12:28 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))

Jul 31 2024

cmassaro removed a subtask for T371572: Test ALL Workflows with Potentially Naughty Escape Sequences: Unknown Object (Task).
Jul 31 2024, 11:51 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a subtask for T371572: Test ALL Workflows with Potentially Naughty Escape Sequences: Unknown Object (Task).
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a subtask for T371572: Test ALL Workflows with Potentially Naughty Escape Sequences: T371561: bug: cannot save python implementation with regex.
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a parent task for T371561: bug: cannot save python implementation with regex: T371572: Test ALL Workflows with Potentially Naughty Escape Sequences.
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro created T371572: Test ALL Workflows with Potentially Naughty Escape Sequences.
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a comment to T371561: bug: cannot save python implementation with regex.

I also see that this works if you double-escape, so the regex can be r'\\d'. This is still not great, but it should work for now.

Jul 31 2024, 11:40 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))