(Translated by https://www.hiragana.jp/)
MediaWiki-Page-diffs
Page MenuHomePhabricator
Projects MediaWiki-Page-diffs

MediaWiki-Page-diffsComponent
ActivePublic
Watch Project

Members (2)

Watchers

  • This project does not have any watchers.
  • View All

Details

Source Repo
https://gerrit.wikimedia.org/g/mediawiki/core/
Description

The Page diff system deals with rendering of differences between two versions of page content. This includes the DifferenceEngine, and the frontend routing logic for it such as the diff= query parameter, and the Special:Diff redirect.

This project is part of the core MediaWiki software itself.

The below are not part of this system:

Recent Activity
View All

Yesterday

Jdlrobson moved T368789: Diff colors in dark mode are not accessible from Backlog to Web on the dark-mode board.
Wed, Jul 3, 1:45 AM · dark-mode, MediaWiki-Page-diffs, Design-System-Team

Tue, Jul 2

Maintenance_bot removed a project from T368789: Diff colors in dark mode are not accessible: Patch-For-Review.
Tue, Jul 2, 6:30 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
gerritbot added a comment to T368789: Diff colors in dark mode are not accessible.

Change #1050485 abandoned by Dtorsani:

[design/codex@main] tokens: Update diff background and border tokens in dark mode

Reason:

As discussed among Web and DST, we will not change these tokens at this time but will address this as a part of T333681.

https://gerrit.wikimedia.org/r/1050485

Tue, Jul 2, 6:05 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF changed the status of T368789: Diff colors in dark mode are not accessible from Open to Stalled.

The Web and Design System teams have decided to log this as a known issue with dark mode that will be addressed once a more holistic approach is determined for diffs as part of T333681.

Tue, Jul 2, 5:13 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF moved T368789: Diff colors in dark mode are not accessible from Triaging to Backlog on the Design-System-Team board.
Tue, Jul 2, 5:13 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF added a parent task for T333681: Establish consistent guidelines on how to visualize diffs across desktop, mobile web, and mobile apps: T368789: Diff colors in dark mode are not accessible.
Tue, Jul 2, 5:11 PM · MediaWiki-Page-diffs, Accessibility, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Design-System-Team
CCiufo-WMF added a subtask for T368789: Diff colors in dark mode are not accessible: T333681: Establish consistent guidelines on how to visualize diffs across desktop, mobile web, and mobile apps.
Tue, Jul 2, 5:11 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF attached a referenced file: F56175283: image.png.
Tue, Jul 2, 5:11 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF added a comment to T368789: Diff colors in dark mode are not accessible.

I also noticed that in the "default" (side-by-side) wikitext diffs, the diff text already has an increased font weight (bold/700), while the inline version does not...

Tue, Jul 2, 4:15 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF updated the task description for T368789: Diff colors in dark mode are not accessible.
Tue, Jul 2, 4:12 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF moved T368789: Diff colors in dark mode are not accessible from Inbox to Triaging on the Design-System-Team board.

I would recommend we keep this open as a known issue until we can further refine the colors as outlined by @DTorsani-WMF in T361717#9939699.

Tue, Jul 2, 4:11 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
CCiufo-WMF renamed T368789: Diff colors in dark mode are not accessible from Inline diff colors in dark mode are not accessible to Diff colors in dark mode are not accessible.
Tue, Jul 2, 4:03 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team

Mon, Jul 1

gerritbot added a project to T368789: Diff colors in dark mode are not accessible: Patch-For-Review.
Mon, Jul 1, 6:21 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
gerritbot added a comment to T368789: Diff colors in dark mode are not accessible.

Change #1050485 had a related patch set uploaded (by VolkerE; author: Dtorsani):

[design/codex@main] tokens: Update diff background and border tokens in dark mode

https://gerrit.wikimedia.org/r/1050485

Mon, Jul 1, 6:21 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team
Aklapper changed the subtype of T368876: Rollback should not display username from "Task" to "Feature Request".
Mon, Jul 1, 9:51 AM · MediaWiki-Patrolling, Anti-Harassment
Aklapper renamed T368876: Rollback should not display username from Rollback spreads abusive usernames. to Rollback should not display username.
Mon, Jul 1, 9:51 AM · MediaWiki-Patrolling, Anti-Harassment
WikiBayer added projects to T368876: Rollback should not display username: MediaWiki-Patrolling, MediaWiki-Page-history, MediaWiki-Page-diffs.
Mon, Jul 1, 8:54 AM · MediaWiki-Patrolling, Anti-Harassment

Fri, Jun 28

Jdlrobson created T368789: Diff colors in dark mode are not accessible.
Fri, Jun 28, 8:16 PM · dark-mode, MediaWiki-Page-diffs, Design-System-Team

Wed, Jun 12

Pppery removed a project from T353062: Core diff on mobile buggy codex thank button: Patch-For-Review.
Wed, Jun 12, 3:35 AM · MediaWiki-Page-diffs, MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Growth-Team, Thanks, MediaWiki-User-Interface

Fri, Jun 7

ReleaseTaggerBot edited projects for T366845: Black dots display on moved lines in diffs, added: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).
Fri, Jun 7, 8:00 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Stashbot added a comment to T366845: Black dots display on moved lines in diffs.

Mentioned in SAL (#wikimedia-operations) [2024-06-07T19:42:13Z] <dduvall@deploy1002> Finished scap: Backport for [[gerrit:1040081|mediawiki.diff: Fix color regression and also use one more token (T366845)]] (duration: 16m 10s)

Fri, Jun 7, 7:42 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Maintenance_bot removed a project from T366845: Black dots display on moved lines in diffs: Patch-For-Review.
Fri, Jun 7, 7:30 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Stashbot added a comment to T366845: Black dots display on moved lines in diffs.

Mentioned in SAL (#wikimedia-operations) [2024-06-07T19:28:35Z] <dduvall@deploy1002> dduvall: Backport for [[gerrit:1040081|mediawiki.diff: Fix color regression and also use one more token (T366845)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Fri, Jun 7, 7:28 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Stashbot added a comment to T366845: Black dots display on moved lines in diffs.

Mentioned in SAL (#wikimedia-operations) [2024-06-07T19:26:03Z] <dduvall@deploy1002> Started scap: Backport for [[gerrit:1040081|mediawiki.diff: Fix color regression and also use one more token (T366845)]]

Fri, Jun 7, 7:26 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
gerritbot added a comment to T366845: Black dots display on moved lines in diffs.

Change #1040081 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.8] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040081

Fri, Jun 7, 7:25 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
gerritbot added a project to T366845: Black dots display on moved lines in diffs: Patch-For-Review.
Fri, Jun 7, 6:22 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
gerritbot added a comment to T366845: Black dots display on moved lines in diffs.

Change #1040081 had a related patch set uploaded (by Dduvall; author: VolkerE):

[mediawiki/core@wmf/1.43.0-wmf.8] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040081

Fri, Jun 7, 6:22 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Volker_E closed T366845: Black dots display on moved lines in diffs as Resolved.
Fri, Jun 7, 5:58 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Maintenance_bot removed a project from T366845: Black dots display on moved lines in diffs: Patch-For-Review.
Fri, Jun 7, 5:30 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
ReleaseTaggerBot added a project to T366845: Black dots display on moved lines in diffs: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).
Fri, Jun 7, 5:00 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
gerritbot added a comment to T366845: Black dots display on moved lines in diffs.

Change #1040212 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040212

Fri, Jun 7, 4:33 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Maintenance_bot removed a project from T176485: Replace the Unicode arrows in wikidiff2 with a neutral symbol and add CSS classes for later styling: Patch-For-Review.
Fri, Jun 7, 4:30 PM · MediaWiki-Page-history, MediaWiki-Page-diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-TechWish, TCB-Team (now WMDE-TechWish)
Volker_E added a comment to T366845: Black dots display on moved lines in diffs.

Thanks @Mormegil, @Jdlrobson and @Pols12 for the digging, patch provided.

Fri, Jun 7, 3:55 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
gerritbot added a project to T366845: Black dots display on moved lines in diffs: Patch-For-Review.
Fri, Jun 7, 3:54 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
gerritbot added a comment to T366845: Black dots display on moved lines in diffs.

Change #1040212 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040212

Fri, Jun 7, 3:54 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Pols12 added a project to T366845: Black dots display on moved lines in diffs: Regression.

(Just for reference: ⚫ is in code because of T176485.
Per Jdlrobson’s investigations, this issue is a regression from MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).)

Fri, Jun 7, 3:49 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Jdlrobson edited projects for T366845: Black dots display on moved lines in diffs, added: Front-end Modernization; removed Desktop Improvements (Vector 2022).

Doesn't seem to be skin specific. Also impacts Monobook and Timeless:
https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=prev&oldid=1227609467&safemode=1&useskin=monobook
https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=prev&oldid=1227609467&safemode=1&useskin=timeless

Fri, Jun 7, 2:18 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Jdlrobson added a parent task for T366845: Black dots display on moved lines in diffs: T365759: Remove IE 11, Edge legacy 15-18, Firefox 39-48, Chrome 31-48 CSS hacks and workarounds in core, extensions and skins.
Fri, Jun 7, 2:17 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Mormegil updated subscribers of T366845: Black dots display on moved lines in diffs.

Same problem here. It seems to me this was caused at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1037742/1/resources/src/mediawiki.diff.styles/diff.less#b268 during T365759 (@Volker_E).

Fri, Jun 7, 8:42 AM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs

Thu, Jun 6

TheDJ added a parent task for T366845: Black dots display on moved lines in diffs: T361402: 1.43.0-wmf.8 deployment blockers.
Thu, Jun 6, 10:05 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Izno updated the task description for T366845: Black dots display on moved lines in diffs.
Thu, Jun 6, 8:29 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs
Izno created T366845: Black dots display on moved lines in diffs.
Thu, Jun 6, 8:24 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), Regression, Front-end Modernization, MediaWiki-Page-diffs

Tue, Jun 4

gerritbot added a project to T24997: HTML link instead of button for 'Compare selected versions'.: Patch-For-Review.
Tue, Jun 4, 8:51 PM · Patch-For-Review, MediaWiki-Page-history, MediaWiki-Page-diffs
gerritbot added a comment to T24997: HTML link instead of button for 'Compare selected versions'..

Change #935486 had a related patch set uploaded (by TheDJ; author: Paladox):

[mediawiki/core@master] Use InnoDB for searchindex and add PK

https://gerrit.wikimedia.org/r/935486

Tue, Jun 4, 8:51 PM · Patch-For-Review, MediaWiki-Page-history, MediaWiki-Page-diffs

May 31 2024

JWheeler-WMF moved T291433: Relocate styles from new mediawiki.diff.styles module from CommTech Backlog to Freezer on the Community-Tech board.
May 31 2024, 7:00 PM · Wikimedia-Performance-recommendation, Community-Tech, MediaWiki-Page-diffs

May 29 2024

CCiufo-WMF reassigned T333681: Establish consistent guidelines on how to visualize diffs across desktop, mobile web, and mobile apps from CCiufo-WMF to DTorsani-WMF.
May 29 2024, 10:25 PM · MediaWiki-Page-diffs, Accessibility, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Design-System-Team

May 27 2024

Jdrewniak removed projects from T313225: [EPIC] Various parts of MediaWiki don't respect default browser font size: FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog.
May 27 2024, 2:46 PM · Web-Team-Backlog, CSS, Design, Accessibility
Jdrewniak moved T313225: [EPIC] Various parts of MediaWiki don't respect default browser font size from Unsorted to Font size on the Accessibility board.
May 27 2024, 2:05 PM · Web-Team-Backlog, CSS, Design, Accessibility
Jdrewniak placed T313225: [EPIC] Various parts of MediaWiki don't respect default browser font size up for grabs.
May 27 2024, 2:00 PM · Web-Team-Backlog, CSS, Design, Accessibility
Jdrewniak added a comment to T313225: [EPIC] Various parts of MediaWiki don't respect default browser font size.

I think this ticket can remain open as a tracking or epic, but various fixes should be handled separately with dedicated tickets, so that the teams responsible for maintaining the repos are made aware of the changes, and potential regressions are easier to track.

May 27 2024, 1:45 PM · Web-Team-Backlog, CSS, Design, Accessibility
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits