Debian Bug report logs - #566672
piuparts fails if testing a package which isn't in the archive

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: submit@bugs.debian.org

Subject: piuparts fails if testing a package which isn't in the archive

Date: Sun, 24 Jan 2010 15:04:22 +0100

[Message part 1 (text/plain, inline)]

package: piuparts
x-debbugs-cc: debian-mentors@lists.debian.org, henrich@debian.or.jp, 
steffen.joeris@skolelinux.de

Hi Hideki,

congratulations! You found a bug in piuparts! :-)

On Samstag, 23. Januar 2010, Hideki Yamane wrote:
> > 0m38.1s INFO: PASS: Installation and purging test.
> > 0m38.1s DEBUG: Starting command: ['chroot', '/tmp/tmpmHa5Fk',
> > 'apt-cache', 'show', 'mecab-naist-jdic-eucjp'] 0m38.3s DUMP:
> >   W: Unable to locate package mecab-naist-jdic-eucjp
> >   E: No packages found


On Sonntag, 24. Januar 2010, Hideki Yamane wrote:
> > how did you run piuparts?
>Well, as usual I run it as below, just with -p option
>$ sudo piuparts -p ./mecab-naist-jdic-eucjp_0.6.1-20090630-1_all.deb

piuparts ran "apt-cache show $package", which failed, because the tested
package is not in the archive yet. Obviously this is a valid usecase and 
piuparts should not fail in this case.

The relevant code is in piuparts.py, line 725ff.

Thanks for using piuparts, I'll try to fix this ASAP.


cheers,
	Holger

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 566672@bugs.debian.org (full text, mbox, reply):

From: Cleto Martin Angelina <cleto.martin@gmail.com>

To: 566672@bugs.debian.org

Date: Tue, 4 May 2010 14:28:37 +0200

Hi!

I'm writing a patch for this bug and after taking a look at code I
have some questions:


if not settings.no_upgrade_test:
    if not settings.args_are_package_files:
        logging.info("Can't test upgrades: -a or --apt option used.")
    elif not chroot.apt_get_knows(packages):
        logging.info("Can't test upgrade: packages not known by apt-get.")
    elif install_upgrade_test(chroot, root_info, selections, package_list,
                                  packages):
        logging.info("PASS: Installation, upgrade and purging tests.")
    else:
        logging.error("FAIL: Installation, upgrade and purging tests.")
        panic()

Member apt_get_knows is where "apt-cache show $package" is executed.
Is it necessary to check if apt knows the packages for doing
install_upgrade_test?. If apt_get_knows returns false,
install_upgrade_test can not be executed?. If it is on this way, my
patch will be oriented to add the package to apt cache. Otherwise, I
think this error may be ignored.

What do you think?

Regards,
 Cleto.

Message #15 received at 566672@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: Cleto Martin Angelina <cleto.martin@gmail.com>, 566672@bugs.debian.org

Subject: Re: [Piuparts-devel] Bug#566672:

Date: Sun, 16 May 2010 13:31:33 +0200

[Message part 1 (text/plain, inline)]

Hi Cleto,

I'm really sorry for the late reply! I'm very happy about you hacking on 
piuparts and I know how the lack of my feedback slowed that down. I'm quite 
unhappy about this, but such is life... 

On Dienstag, 4. Mai 2010, Cleto Martin Angelina wrote:
> Hi!
>
> I'm writing a patch for this bug and after taking a look at code I
> have some questions:
>
>
> if not settings.no_upgrade_test:
>     if not settings.args_are_package_files:
>         logging.info("Can't test upgrades: -a or --apt option used.")
>     elif not chroot.apt_get_knows(packages):
>         logging.info("Can't test upgrade: packages not known by apt-get.")
>     elif install_upgrade_test(chroot, root_info, selections, package_list,
>                                   packages):
>         logging.info("PASS: Installation, upgrade and purging tests.")
>     else:
>         logging.error("FAIL: Installation, upgrade and purging tests.")
>         panic()
>
> Member apt_get_knows is where "apt-cache show $package" is executed.
> Is it necessary to check if apt knows the packages for doing
> install_upgrade_test?. 

yes. 

> If apt_get_knows returns false, 
> install_upgrade_test can not be executed?. If it is on this way, my
> patch will be oriented to add the package to apt cache. Otherwise, I
> think this error may be ignored.

if the package is not known to apt, piuparts should say so, do the 
installation and removal test and skip the upgrade test (and say so).


cheers,
	Holger

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 566672@bugs.debian.org (full text, mbox, reply):

From: Cleto Martin Angelina <cleto.martin@gmail.com>

To: Holger Levsen <holger@layer-acht.org>, 566672@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#566672: [Piuparts-devel] Bug#566672:

Date: Thu, 10 Jun 2010 09:42:31 +0200

[Message part 1 (text/plain, inline)]

tags 566672 + patch
thanks.

Hi! Sorry about my lag :-)...

I think the attached patch solves this problem. I have tested it with
two packages: first one is known by apt-get previously and upgrade
test is done for it. The other package is not known, so piuparts
informs about that the upgrade test is not possible.

Mainly, the patch is based on the documentation of apt-cache. Its
manual page say that "apt-cache returns zero on normal operation,
decimal 100 on error". With all this, I think it is enough to check if
the return code status is non-zero. I don't know if I have missed
something, so I am cautious saying this :-).

Cheers,
 Cleto.

[apt_knows_patch.diff (text/x-patch, attachment)]

Message #27 received at 566672@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: Cleto Martin Angelina <cleto.martin@gmail.com>, 566672@bugs.debian.org

Subject: Re: [Piuparts-devel] Bug#566672: Bug#566672:

Date: Mon, 14 Jun 2010 14:08:27 +0200

[Message part 1 (text/plain, inline)]

Hi Cleto,

On Donnerstag, 10. Juni 2010, Cleto Martin Angelina wrote:
> Hi! Sorry about my lag :-)...

no problem at all, I'm lagging too ;-)

> Mainly, the patch is based on the documentation of apt-cache. Its
> manual page say that "apt-cache returns zero on normal operation,
> decimal 100 on error". With all this, I think it is enough to check if
> the return code status is non-zero. I don't know if I have missed
> something, so I am cautious saying this :-).

And thats why I'm cautious to apply it. I need some time to review and test it 
first.


Thanks,
	Holger

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 566672-close@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@debian.org>

To: 566672-close@bugs.debian.org

Subject: Bug#566672: fixed in piuparts 0.39

Date: Tue, 04 Jan 2011 13:32:06 +0000

Source: piuparts
Source-Version: 0.39

We believe that the bug you reported is fixed in the latest version of
piuparts, which is due to be installed in the Debian FTP archive:

piuparts_0.39.dsc
  to main/p/piuparts/piuparts_0.39.dsc
piuparts_0.39.tar.gz
  to main/p/piuparts/piuparts_0.39.tar.gz
piuparts_0.39_all.deb
  to main/p/piuparts/piuparts_0.39_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 566672@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Levsen <holger@debian.org> (supplier of updated piuparts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 04 Jan 2011 14:12:30 +0100
Source: piuparts
Binary: piuparts
Architecture: source all
Version: 0.39
Distribution: unstable
Urgency: low
Maintainer: piuparts developers team <piuparts-devel@lists.alioth.debian.org>
Changed-By: Holger Levsen <holger@debian.org>
Description: 
 piuparts   - .deb package installation, upgrading, and removal testing tool
Closes: 526046 539146 560050 566597 566599 566672 567190 573904 574504 574936 576321 586443 586793 591966 594964 602409 603453 605127 605475
Changes: 
 piuparts (0.39) unstable; urgency=low
 .
   [ Holger Levsen ]
   * The vintage of 2010 release!
   * piuparts-report.py:
      - report packages which failed
        - due to broken maintainer scripts,
        - due to output from cron after removal,
        - due to not enough force being,
        - due to a problem with pre-depends,
        - due to files having been modified after purge,
        - due to files having disappeared after purge and
        - due to problems configuring a database.
      - only report about (un)owned files and directories and symlink issues in
        sid - that's hardcoded as it's not practical to track them anywhere else
        anyway. And at least for broken symlinks this will also stay like this
        for a long time.
      - visual improvements in the output.
      - ignore udebs and binaries from other archs too.
      - graph is generated using all the available data points.
   * piupartslib/packagesdb.py:
     - automatically break circular dependencies when there are only circular
       dependencies left, using a configurable list of circular depdencies in
       piuparts.conf (Closes: #526046)
         The list of circular depends is taken from a script written by Robert
       Lemmen available at http://debian.semistable.com/debgraph.out.html -
       obviously it would be better to merge this into piuparts directly.
         Note that the dependency resovler is still buggy, the state
       waiting-for-dependency-to-be-tested still contains some packages
       with failed depends (due to them being dependent on packages with
       circular depends). This bug has no effect other than that (so the state
       waiting-to-be-tested is calculated correctly). This bug is also no
       regression.
     - get rid of the longtime unused states "fixed" and "fix-not-yet-tested"
       (also in piuparts-master and piuparts-report).
     - forget reservations of untestable packages.
   * piuparts-slave.py:
     - fix crash when going into sleep when idle.
     - add support for only doing upgrade tests (without the basic test in the
       upgrade target distro).
     - honor mirror configuration option also for upgrade-tests.
     - also do upgrade tests if the version of a package being tested (the one
       in the upgraded distro) is not available in the distro being upgraded
       from. (This is a very short test, but a successfully one.)
     - make configuration setting "distro" to not default to any distro.
   * piuparts.py:
     - new option: --log-level to specify the verbosity of piuparts
       output. Thanks to Fabrice Coutadeur for the patch! (Closes: #567190)
     - new option: --warn-on-leftovers-after-purge to not fail if a package
       leaves files behind after purge. (Closes: #566599)
     - add to self.ignored_files:
       - /var/lib/apt/lists/partial/.delete-me-later
       - /var/log/alternatives.log (Closes: #591966)
       - /var/log/apt/history.log (Closes: #594964)
       - /usr/share/fonts/X11/misc/fonts.alias (Closes: #576321)
     - add to self.ignored_patterns:
       - /etc/init.d/.depend.*
       - /var/mail(/.*)? - this used to be just /var/mail/.*
       - /var/lib//update-rc.d(/.*)? (Closes: #605127)
     - create temporary DEBIAN directory for the piuparts-depends-dummy package
       with 0755 perms regardless of the umask of the calling shell.
       (Closes: #573904)
     - fix --do-not-verify-signatures option (Closes: #574936) - thanks to
       Cleto Martin Angelina for the patch.
     - make Chroot.diff_meta_data() special case and ignore files matching
       (/etc/rc.\.d/)[SK][0-9]{2}(.*)$ so that piuparts doesn't complain about
       initscripts renamed by insserv. Thanks to by Andreas Beckmann for the
       patch! (Closes: #586793)
     - remove logrotate and depended packages after the test. (Closes: #602409)
       This is a fix for the incomplete patch for #566597. Again, this is a
       hardcoded list. :-(
     - new custom script: pre_remove_ (Closes: #539146)
     - set environment variable PIUPARTS_OBJECTS in custom scripts to a space
       separated list of packages / changes files being tested.
     - do not call apt-get with --no-remove when installing packages.
       (Closes: #603453)
     - apply patch by Andres Mejia to fix parsing of the --force-confdef option
       and also to configure apt to use that option. Thanks, Andres.
       (Closes: #605475)
     - don't panic if package is not known by apt-get, this probably just means
       a package not yet in the archive is being tested. (Closes: #566672)
       Thanks to Cleto Martin Angelina for the patch!
     - fix parsing of the options --end-meta and --save-end-meta.
     - supply help texts for --end-meta and --save-end-meta options, also add
       comments to install_and_upgrade_between_distros() to make the code
       easier to understand and hopefully improve in future. (Closes: #560050).
     - add logging to install_and_upgrade_between_distros() to point people to
       read the functions source code if they wonder why the log (for distro
       upgrade tests) looks like it looks.
   * piuparts.1.txt:
     - update the pointer to custom-scripts.txt to point to README.txt, as
       those two files have been merged. Thanks to Gregor Hermann for
       spotting this. (Closes: #574504)
     - indicate that it's possible to check several packages or .changes files
       at once.
     - update several options descritpions.
   * README.txt
     - better documentation of custom scripts.
     - reformat to achieve consistent width.
   * Add ${misc:Depends} to Depends in debian/control.
   * Remove versioned dependencies on debootstrap as the version available
     in Etch is sufficient. Drop build-depends on dpkg-dev as it's in
     build-essential.
   * Build-depend on debhelper>=7 and use dh_prep instead of dh_clean -k, bump
     compat level to 7.
   * Bump Standards-Version to 3.9.1, no changes necessary.
   * Remove Ian Jackson from uploaders - thanks for your work, Ian!
   * Makefile: support python 2.5 and 2.6 instead of 2.4 and 2.5, adjust
     debian/control accordingly.
   * debian/preinst: update code snipplet rm_conffile() from
     http://wiki.debian.org/DpkgConffileHandling
 .
   [ Evgeni Golov ]
   * piuparts.py:
     - Check for remaining logrotate files which produce output after the
       package was removed. (Closes: #566597)
 .
   [ John Wright ]
   * Use debian module when available, else debian_bundle module.
     (Closes: #586443)
   * Use built-in set type, available since python-2.4.
Checksums-Sha1: 
 3c3ad00dd7addfaf40f218eb1ec93210ea74b095 958 piuparts_0.39.dsc
 5211856496fd9cd2658d981d446d51195888e2df 89592 piuparts_0.39.tar.gz
 c1398adc45bfdee899ce2eb53d7d62820bedda5f 89058 piuparts_0.39_all.deb
Checksums-Sha256: 
 6d8fa026c3b78d3ce3ad9d73541bdc037da8c19dbce9876e36c9635eb2f44478 958 piuparts_0.39.dsc
 48236ad5597920eaf3ddda94837017ef81b1fca0325a675f96e2e747dc452e7d 89592 piuparts_0.39.tar.gz
 91c108e7894ca839bcecb7b02bf33a2e591b4d42d4d151ce3fdf9996849c658a 89058 piuparts_0.39_all.deb
Files: 
 dd7e3bfca6a78a537d3b3b9dd712a88e 958 devel extra piuparts_0.39.dsc
 ea307563f91e61fcb290c34e659180b4 89592 devel extra piuparts_0.39.tar.gz
 c78f819525585192c86e6ef464e927c6 89058 devel extra piuparts_0.39_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFNIx7OUHLQNqxYNSARAkQzAKDLwuruQfaidyvB27YZUimxAvfPDwCggnqc
3pBYfUI+lwCYZex4CnaOQUU=
=vMrp
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.