DannyS712 bot
|
|
Task 3 – Draft categories
editHello. I noticed your bot converting draft cats to links, which is much better than deleting them; so thanks for that task. May I ask you to go one step further, and instead of converting it to links, embed the categories in template {{Draft categories}} instead? The effect will be that the categories will be shown at the foot of the Draft page, without populating the categories, and when the draft is released, they will immediately populate the correct categories with no further intervention.
For example, instead of performing this edit at Draft:Gallo-Roman Theater of Lisieux, you would do this instead:
− | {{Portal|Ancient Rome|Architecture
}}
[[Category:Ancient Roman theatres in France]]
[[Category:Roman amphitheatres in France]]
[[Category:Roman Gaul]] | + | {{Portal|Ancient Rome|Architecture
}}
{{Draft categories|
[[Category:Ancient Roman theatres in France]]
[[Category:Roman amphitheatres in France]]
[[Category:Roman Gaul]]
}} |
- For example, see the footer of Draft:Contravention in French criminal law, which uses this template.
- An example of a mainspace article which uses it is Tinio Brigade; they evidently forgot to remove the template, but that's what's so good about it, because it doesn't matter if they remove it or not, as categorization will work correctly either way, whereas if you forget to remove the colons from the links, they will not work correctly.
Would this change be possible? Thanks, Mathglot (talk) 00:42, 4 June 2024 (UTC)
- This was inspired by this subsection of a longer conversation, and an issue was raised about whether the scope of the bot could be broadened to all drafts, not just those with the submit template. Can it? I've left a related message at User talk:Primefac#PrimeBot and avoiding categories in Drafts. Mathglot (talk) 17:28, 4 June 2024 (UTC)
- Is any change likely on this? Is there any way to stop this 'bot until it does? Andy Dingley (talk) 19:20, 10 June 2024 (UTC)
- The key question here for me is does the AFHC script support {{Draft categories}}, or does it need to be patched before this change is made? Mdann52 (talk) 04:42, 11 June 2024 (UTC)
- Mdann52, yes. — Qwerfjkltalk 18:21, 11 June 2024 (UTC)
- Mdann52, I am unfamiliar with AFHC; an advanced search turned up WP:WikiProject Articles for creation/Helper script (WP:AFCH)—is that what is meant? If so, would you mind elaborating on the connection between that and the topic question? Thanks, Mathglot (talk) 22:03, 11 June 2024 (UTC)
- Yes it's the AFC Helper Script - it's important as it's the main tool reviewers use to process these submissions. If it wasn't supported by the script, we risk reviewers not cleaning the template up when approving.
- However, it sounds like the script handles it and the template works in mainspace, so my concerns are sorted. Mdann52 (talk) 05:27, 12 June 2024 (UTC)
- The key question here for me is does the AFHC script support {{Draft categories}}, or does it need to be patched before this change is made? Mdann52 (talk) 04:42, 11 June 2024 (UTC)
Great, so that brings us back to square one: DannyS712, is the proposal above to use {{Draft categories}} instead of links workable? Mathglot (talk) 05:53, 12 June 2024 (UTC)
- @Mathglot so technically my bot approval was only for converting to links (Wikipedia:Bots/Requests for approval/DannyS712 bot 3) but I also am not quite sure how what regex to use other than having a single {{Draft categories}} around each category, which would be a bit ugly. Let me think about this for a bit. A probably easier thing to do would be to update the helper script to restore categories like this (or at least I was going to suggest that, but it looks like it is already the case - https://github.com/wikimedia-gadgets/afc-helper/blob/d4d8ef6088bc99b96bf1c2247868cdb7819f06e7/src/modules/submissions.js#L545). --DannyS712 (talk) 06:02, 12 June 2024 (UTC)
- Understood, thanks. Imho, since it’s only a draft, only visible in the wikicode and not on the rendered page, it’s worth it, as ugly wikicode in exchange for saving countless hours of editor time is a good tradeoff. But let’s think some more about it and see what other opinions might be forthcoming from others. Mathglot (talk) 06:40, 12 June 2024 (UTC)
- DannyS712, Not sure what flavor of regex you are using, but what about this via perl:
# Match one or more contiguous category lines my $pattern = qr/^(?:\[\[Category:[^]]+\]\]\n?)+$/m; # Replacement pattern to embed in Draft categories template $text =~ s/($pattern)/{{Draft categories |\n$1}}/s;
Listed at: Wikipedia:Bot requests#Friendly support for Draft categories – feedback request. Mathglot (talk) 19:42, 10 June 2024 (UTC)
DannyS712 Still interested. Can we use {{Draft categories}} instead? This would be a huge time-saver, if it could be implemented. Mathglot (talk) 08:55, 24 June 2024 (UTC)
- Permission to modify the bot approval requested at Wikipedia talk:Bots/Requests for approval/DannyS712 bot 3 --DannyS712 (talk) 04:03, 2 July 2024 (UTC)
- Thanks, monitoring... Mathglot (talk) 04:45, 2 July 2024 (UTC)
- Fwiw, an analogous issue regarding an AFC helper script that performs similar actions to the bot regarding draft categories was previously raised by Novem Linguae here, as reported by a user at WT:AFC. Mathglot (talk) 09:18, 5 July 2024 (UTC)
- I saw the good news about your bot modification approval. Please keep me informed as things progress, or if you hit any roadblocks. Thanks, Mathglot (talk) 22:14, 20 July 2024 (UTC)
- @Mathglot okay - I'm back in town and should be able to do this soon, I'm keeping a to-do list of bot stuff and its on it DannyS712 (talk) 02:42, 21 July 2024 (UTC)
- @Mathglot should be doing this now, first edit at Special:Diff/1236674064 --DannyS712 (talk) 00:18, 26 July 2024 (UTC)
- Thanks. Is there a test cases page somewhere? If it's okay with you, I might like to add a test case or two. For example: if there is a blank line (two newlines) between categories, I think it's okay if you don't catch that case; we just have to handle that in the documentation, and say it won't be handled if they do that. Ditto with white space before or after the colon or brackets, and so on. Of course, if you can create a stronger regex that would skip extra newlines and white space, so much the better, but not if that risks making the regex more fragile. I could add a test case for that, if you like; lmk. Mathglot (talk) 05:30, 26 July 2024 (UTC)
- If you want to create a test cases page that would be great, no objections from me - the bot currently doesn't pay attention to whether things are within nowiki tags are not, so if you put all of the categories into a nowiki block then the categories won't take effect but the bot would still process it (as long as it is categorized as an AFC draft with categories, which you can add manually). Feel free to create this as a subpage of the bot user page --DannyS712 (talk) 07:23, 26 July 2024 (UTC)
- Still open; please do not archive. Mathglot (talk) 07:38, 30 September 2024 (UTC)
- If you want to create a test cases page that would be great, no objections from me - the bot currently doesn't pay attention to whether things are within nowiki tags are not, so if you put all of the categories into a nowiki block then the categories won't take effect but the bot would still process it (as long as it is categorized as an AFC draft with categories, which you can add manually). Feel free to create this as a subpage of the bot user page --DannyS712 (talk) 07:23, 26 July 2024 (UTC)
- Thanks. Is there a test cases page somewhere? If it's okay with you, I might like to add a test case or two. For example: if there is a blank line (two newlines) between categories, I think it's okay if you don't catch that case; we just have to handle that in the documentation, and say it won't be handled if they do that. Ditto with white space before or after the colon or brackets, and so on. Of course, if you can create a stronger regex that would skip extra newlines and white space, so much the better, but not if that risks making the regex more fragile. I could add a test case for that, if you like; lmk. Mathglot (talk) 05:30, 26 July 2024 (UTC)
- @Mathglot should be doing this now, first edit at Special:Diff/1236674064 --DannyS712 (talk) 00:18, 26 July 2024 (UTC)
- @Mathglot okay - I'm back in town and should be able to do this soon, I'm keeping a to-do list of bot stuff and its on it DannyS712 (talk) 02:42, 21 July 2024 (UTC)
June 2024
editPlease refrain from making unconstructive edits to Wikipedia, as you did at Draft:Tenzing Norgay Trainor. Your edits appear to be disruptive and have been or will be reverted.
- If you are engaged in an article content dispute with another editor, please discuss the matter with the editor at their talk page, or the article's talk page, and seek consensus with them. Alternatively, you can read Wikipedia's dispute resolution page, and ask for independent help at one of the relevant noticeboards.
- If you are engaged in any other form of dispute that is not covered on the dispute resolution page, please seek assistance at Wikipedia's Administrators' noticeboard/Incidents.
Please ensure you are familiar with Wikipedia's policies and guidelines, and please do not continue to make edits that appear disruptive. Continued disruptive editing may result in loss of editing privileges. Corrupted category list in draft article already disabled as in {{draftcat}}
section. Ignored report on this bug on bot. Please fix this Geraldo Perez (talk) 01:00, 12 June 2024 (UTC)
- Pinging User:DannyS712. The categories were already enclosed with {{draftcat}}. Looking at line 77, you're using the regex
{{Draft categories\|[^{}]+}}
, but that doesn't match the redirect this user is using, and you might want to consider this for the future. - Anyways, I've gone ahead and changed the template to {{Draft categories}} so the bot will stop editing it. Thanks, Rusty4321 talk contribs 02:10, 12 June 2024 (UTC)
- @Rusty4321 thanks for letting me know, I will update the bot when I have a chance. --DannyS712 (talk) 05:19, 12 June 2024 (UTC)
- @Geraldo Perez I don't log in with the bot account manually and wasn't pinged on the reports above so I didn't know about it - in the future if you just let me know on my talk page (or with a ping like I just got) I can fix this. I didn't "ignore" the report, just didn't see it --DannyS712 (talk) 05:22, 12 June 2024 (UTC)
- @Geraldo Perez @Rusty4321 should be working now, I updated the code https://github.com/DannyS712/bot/commit/3d4e469a3e94aa70805e8a5a5f9d1519cadc8c5b and just deployed it. Please let me know if this happens again --DannyS712 (talk) 05:36, 12 June 2024 (UTC)
I have sent you a note about a page you reviewed
editHi DannyS712 bot. Thank you for your work on 2024 Malaysia A2 Amateur League. Another editor, MPGuy2824, has reviewed it as part of new pages patrol and left the following comment:
DannyBot should not be reviewing redirects to draftspace.
To reply, leave a comment here and begin it with {{Re|MPGuy2824}}
. (Message delivered via the Page Curation tool, on behalf of the reviewer.)
-MPGuy2824 (talk) 13:46, 1 July 2024 (UTC)
- @DannyS712: FYI. -MPGuy2824 (talk) 13:48, 1 July 2024 (UTC)
- @MPGuy2824 thanks, but the bot is operating as expected - the redirect shouldn't have been created in the first place. I think this is enough of an edge case that it is unlikely to be a problem, since redirects to drafts are quickly deleted by patrolling admins --DannyS712 (talk) 04:00, 2 July 2024 (UTC)
redirects to drafts are quickly deleted by patrolling admins
. This is true if the relevant speedy deletion tags are added. I did that for this redirect, and not the editor who moved the article to draftspace. The problem is that most NPP scripts and reports only care about unreviewed redirects (and articles) and a report just happened to catch this redirect before your bot reviewed it. Anyway, if this is hard to code for, then you should assign it a low priority. If you do get other editors/reviewers complaining about stuff like this, then you can reconsider that priority. Happy editing! -MPGuy2824 (talk) 09:17, 2 July 2024 (UTC)
- @MPGuy2824 thanks, but the bot is operating as expected - the redirect shouldn't have been created in the first place. I think this is enough of an edge case that it is unlikely to be a problem, since redirects to drafts are quickly deleted by patrolling admins --DannyS712 (talk) 04:00, 2 July 2024 (UTC)
DannyS712 bot III "double patrolling" redirects
edit@DannyS712: DannyS712 bot III seems to be patrolling some redirects twice. See the logs of ATLASerials and Roy cooper for examples. Thanks, Queen of Hearts talk 00:02, 26 July 2024 (UTC)
- Yeah it is because I just restarted the bot and there might be some duplicates, it shouldn't be happening anymore DannyS712 (talk) 00:04, 26 July 2024 (UTC)
Bot is down
edit@DannyS712 NotAGenious (talk) 17:07, 30 August 2024 (UTC)
- @DannyS712: I guess you fixed the problem then, but the bot has gone down again on 25 Sep ( going by [1]). Please check. -MPGuy2824 (talk) 05:43, 30 September 2024 (UTC)
- Backup bot is DreamRimmer bot. – DreamRimmer (talk) 06:06, 6 October 2024 (UTC)
Question about a recent patrol
editWhy did the bot patrol YOU SUCK!—is it because I am on the whitelist and I refined the target? I was sort of intentionally leaving that in a slightly improved state for a second set of eyes to have a glance and determination at, which is why I was wondering. — Godsy (TALKCONT) 03:40, 17 September 2024 (UTC)
BLP error
editBot patrolled an unsourced BLP written in Bosnian [2]. The page has been reverted as redirect (at present) by another user. Significa liberdade (she/her) (talk) 19:10, 5 November 2024 (UTC)