-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GIF Player UI extension (/gifplayer.htm) #3921
base: gif
Are you sure you want to change the base?
Conversation
- loading spinner now showing on upload - hostname value now trimmed and checked for change before refresh - remove invisible upload button
Works okay with one note ( may be not related directly to the html page ) is that the storage size reported of 241/983 KB is not accurate and it will only report the correct number once you reboot the esp which is the same behavior on the filesystem info page . |
@Manut38 Does your PR build on top of the PR from Aircoookie for GIF support, or is it independent? |
@dosipod Yes, I did notice that behavior too. I'm just getting this info straight from the /json/info endpoint. I don't know of any other way to check for the current values. @softhack007 This is essentially a separate interface, specialized in controlling the new "Image" effect, added by Aircoookie in the gif branch. So it is built on top of that functionality. |
they will now use the existing presets, even if they were previously renamed
essentially sending the "off" command
- move advanced features to config dialog
I made a few changes to the code since I took the screenshots that I would love to hear your opinion on.
Another thing I want to note is that I am very aware that this is building on top of a feature that is still currently in-development. Especially because of that I would be interested in @Aircoookie's opinion, because as far as I know he was the one mostly working on the "Image" effect. |
Updated the images to reflect the changes to the button layout. |
@Manut38 I am personally not in favor of adding such external tools to wled at build time just from the points that future updates to wled might break things( this has been seen with other tools a lot ) and if your tool is separate then it could be updated faster which we also seen first hand . Does not harm to maintain your page though , please post about the same on wled discord 2D channel At the moment we use a lot of tools like that and we just download the latest version and copy under edit , i am not sure what is wrong with that if any . That is beside the fact that gif is not merged yet |
@dosipod I kind of agree with this honestly. This pull request was motivated by the fact that there are some other tools that have been integrated into the source directly and also got mentioned on the official wiki. I saw that the "older" WLED-PixelArtConverter [pixartmin.htm] got a separate entry in the wiki at https://kno.wled.ge/features/pixel-art-converter/ |
@Manut38 when (or if) GIF player gets merged and @Aircoookie decides that this UI extension is usable and merges this PR you can make a PR for WLED documentation so that it gets attention of users. |
The idea was really good, huh? hahah! I'll test it and let you know what I think, I'm out of date... I didn't even know it had gif support already. It looks very promising. If possible @Manut38 , can I adapt what you did to my project? Looking at yours gave some very interesting ideas! |
@ajotanc Oh I'm sorry, I missed this reply! However I'm pretty sure, that whenever the gif branch will be merged it will be the more versatile and faster solution for animations. Of course you can take any inspiration you like from my code, it's open source after all and it's also the exact same thing I did with your code before 😄 |
I wrote a little UI extension page for the new GIF support and I would love to have it included in this project.
Thanks to @ajotanc, whose PixelMagicTool I used as a base for my layout and structure!
I also included a "GIF" button right next to the pxmagic.htm button.
This is merely an idea and of course I'm happy to take suggestions about the placement or about the implementation in general.
Source: https://github.com/Manut38/WLED-GifPlayer-html
Thank you all so much for your work on WLED, it's honestly amazing!!
I've been using it for the last couple of years now and I love to see how it developed over that time. GIF support finally being added is all I that dreamed about 🔥
A WLED UI extension for an easy control of the awesome new "Image" effect, capable of displaying animated GIFs on your LED matrix.
It is using the ESP filesystem editor at
/edit
to list and change files on the local ESP storage.Features
Limitations
Warning
Only upload images in your matrix native resolution! (e.g. 16x16)
Due to the limited flash storage space and processing power, .gif files of larger dimensions will make the effect lag and kill WLED performance
Screenshots