feat(metrics): use delta value on reporting percentile metrics #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SCNieh
commented
Apr 18, 2024
SCNieh
commented
- introduced DeltaHistogram to record distribution of values, sample sequence will be reset based on reporting interval
- removed mean metrics for histogram type metrics, from now on mean metrics should be derived from sum and count
1. introduced DeltaHistogram to record distribution of values, sample sequence will be reset based on reporting interval 2. removed mean metrics for histogram type metrics, from now on mean metrics should be derived from sum and count Signed-off-by: Shichao Nie <niesc@automq.com> Signed-off-by: Shichao Nie <niesc@automq.com>
ShadowySpirits
previously approved these changes
Apr 18, 2024
superhx
previously approved these changes
Apr 18, 2024
Signed-off-by: Shichao Nie <niesc@automq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.