(Translated by https://www.hiragana.jp/)
communicate() blocks, how to make it non-blocking · Issue #13 · Ch00k/ffmpy · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communicate() blocks, how to make it non-blocking #13

Closed
busla opened this issue Nov 7, 2016 · 3 comments
Closed

communicate() blocks, how to make it non-blocking #13

busla opened this issue Nov 7, 2016 · 3 comments

Comments

@busla
Copy link

busla commented Nov 7, 2016

When running ffmpy in the background I needed to remove the communicate() call in https://github.com/Ch00k/ffmpy/blob/master/ffmpy.py#L103.

I think I´m not understanding the subprocess module properly so do you have any suggestions on how to make the subprocess non-blocking?

Cheers.

@busla
Copy link
Author

busla commented Nov 7, 2016

see:
busla@0996274

@Ch00k
Copy link
Owner

Ch00k commented Nov 7, 2016

@busla Would running ffmpy in a separate thread work for your scenario?

@busla
Copy link
Author

busla commented Nov 7, 2016

Yes it would, that´s actually how I implemented my project in the beginning, but soon realised that it was unnecessary.

FFmpy is now run on my class instances and added as a class variable so I can terminate it when I flag my instance to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants