Error fetch_fcst task when no data found for a model, as it usually indicates a typo in the data path #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also gone through and removed some unneeded things, added titles, etc. Still need to go through the diagnostics. Split diagnostics into sections, add input variable table Also link in more models, so 10 are now supported. Improvements to rose edit metadata Fix a bunch of validation issues
Also now use subclasses for getting individual files from the various data sources.
Grab rose template variables directly, rather than via jinja context Add workflow exported functions to __all__ Add licence header to jinja_utils Require success for processing tasks in workflow Housekeep only on success, but finish workflow regardless
…them I've updated one recipe for now, but they will all have to be converted.
The final cycle point task are skipped if doing a continuous trial without a defined end date.
They have all been replaced my the more generic version that work for both the UM and LFRic.
Use cycle point for deterministic resolving.
It was also invalid due to referencing non-existent variables.
Also rearrange pressure level metadata.
Q-Q plot recipe is partially converted, pending Issue #808.
The operator now requires all arguments to either be numbers, or all be None if you don't want to constrain the area. The test has been mildly improved, so at least it checks for both of the named functions on the coordinates, though it still doesn't test that they do anything.
jfrost-mo
added
bug
|
I probably need to add a test before merging. |
jfrost-mo
commented
Sep 25, 2024
jfrost-mo
force-pushed
the
824_error_when_no_data_found
branch
2 times, most recently
from
ebefa09
to
19b6a62
Compare
|
|
jfrost-mo
changed the title
jfrost-mo
changed the title
|
Tests could do with actually checking the return value if the FileRetrievers. |
|
Marking as draft after it didn't work when tested during the NIWA tutorial. |
jfrost-mo
force-pushed
the
824_error_when_no_data_found
branch
from
2cbc846
to
83bafc8
Compare
It is invalid rose syntax. Also use !! to disable showing the option in the GUI.
This should catch the case where the underlying implementation is not correctly reporting when files are missing.
jfrost-mo
force-pushed
the
824_error_when_no_data_found
branch
from
83bafc8
to
1b54c3f
Compare
|
I've added some more tests, and manually tested. It seems to work... Maybe we just forgot to merge properly into the NIWA branch? |
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
28a9e02
to
64da0c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #824
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.