-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins: add ddc.vim and related plugins #293289
Conversation
Those plugins depend on each other, could you please specify it similar to here? |
I verified the rebased-and-updated plugins in this PR still work with my vim setup! Other than needing to still add the For anyone curious, my setup/use of these is over here, with these two PRs pulled in via an overlay. |
Now that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
CC @teto
shouldn't that depend on a |
They do indirectly!
I could explicitly add the |
my bad, was too lazy to check it out. Patching denops-vim (vimPlugins in general is tough). Is there a way to setup the path towards deno without patching the plugin, via configuration for instance, like |
There's indeed the The current approach feels nice to me, since changing that external config's default value via adding an extra autoload file or such would, well, change the observable default value. |
thanks. Good to know. There is no clear stance on how to package the vim plugins. I would like to avoid patching as much as possible because it's bad practice (makes upstream debugging harder) but alternatives are not great for now. |
Description of changes
This adds the most commonly used set of ddc.vim plugins, or at least the set I use as part of my completion setup.
You can read more about ddc.vim over here: https://github.com/Shougo/ddc.vim
I've manually tested that these plugins work with my vim setup, and so far I've been maintaining an overlay for them. I'm hoping to be able to upstream them so others can benefit, and to simplify my own setup.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)