(Translated by https://www.hiragana.jp/)
vimPlugins: add ddc.vim and related plugins by euank · Pull Request #293289 · NixOS/nixpkgs · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: add ddc.vim and related plugins #293289

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

euank
Copy link
Member

@euank euank commented Mar 4, 2024

Description of changes

This adds the most commonly used set of ddc.vim plugins, or at least the set I use as part of my completion setup.

You can read more about ddc.vim over here: https://github.com/Shougo/ddc.vim

I've manually tested that these plugins work with my vim setup, and so far I've been maintaining an overlay for them. I'm hoping to be able to upstream them so others can benefit, and to simplify my own setup.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@PerchunPak
Copy link
Member

Those plugins depend on each other, could you please specify it similar to here?

@euank
Copy link
Member Author

euank commented Aug 22, 2024

I verified the rebased-and-updated plugins in this PR still work with my vim setup!

Other than needing to still add the pum dependency (per comment thread above), I'm happy with this.

For anyone curious, my setup/use of these is over here, with these two PRs pulled in via an overlay.

@euank
Copy link
Member Author

euank commented Aug 23, 2024

Now that the pum-vim PR merged, I've updated ddc-ui-pum to have that dependency; as far as I know, this is good to go!

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

CC @teto

@teto
Copy link
Member

teto commented Aug 24, 2024

shouldn't that depend on a deno runtime somewhow ?

@euank
Copy link
Member Author

euank commented Aug 24, 2024

They do indirectly!

denops-vim depends on deno here, ddc-vim depends on denops-vim, and all of these depend on ddc-vim.

I could explicitly add the denops dependency for all of them as well, but I believe as-is they'll always pull in deno via denops.

@teto
Copy link
Member

teto commented Aug 24, 2024

my bad, was too lazy to check it out. Patching denops-vim (vimPlugins in general is tough). Is there a way to setup the path towards deno without patching the plugin, via configuration for instance, like vim.g.denops_runtime = ....
It's tangential to this PR that I approve, just curious.

@euank
Copy link
Member Author

euank commented Aug 24, 2024

There's indeed the g:denops#deno setting, so people can override it if they want that way.

The current approach feels nice to me, since changing that external config's default value via adding an extra autoload file or such would, well, change the observable default value.

@teto
Copy link
Member

teto commented Aug 24, 2024

thanks. Good to know. There is no clear stance on how to package the vim plugins. I would like to avoid patching as much as possible because it's bad practice (makes upstream debugging harder) but alternatives are not great for now.
I am thinking about having the neovim wrapper collect configurations from the plugins and autoadd it to its config ?!
You can read about this here #172538.
Waiting for CI before merge

@natsukium natsukium merged commit b37c9c3 into NixOS:master Sep 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants