sheldon: enable on unix platforms

[yasunori0418]

…is not possible in mac environment

Description of changes

When installing sheldon on x86_64-darwin, it failed because the platform was not supported.
So, when I tried building it directly at hand, I was able to build it in the environment I was using, so I don't think it is necessary to specify platforms.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[donovanglover]

Welcome to nixpkgs! Please follow the commit message guidelines in CONTRIBUTING.md. You should also edit the PR title to match the new commit message.

As an example, your commit message can be something like this: sheldon: enable on all platforms

[yasunori0418]

Welcome to nixpkgs! Please follow the commit message guidelines in CONTRIBUTING.md. You should also edit the PR title to match the new commit message.

As an example, your commit message can be something like this: sheldon: enable on all platforms

Sorry, I have corrected the commit message and PR title.

[Bot-wxt1221]

@yasunori0418 We must ask the maintainers if they can maintain darwin. If not, you can help with this.

[yasunori0418]

@yasunori0418 We must ask the maintainers if they can maintain darwin. If not, you can help with this.

The Mac book I'm currently using is not personally owned but by a company, so it's difficult to continue using it for package maintenance and become a maintainer...
I'm sorry that I can't help you as a maintainer.

[jopejoe1]

Platforms should still be set and to include darwin and other unix systems platforms.unix or to inclide non unix systems could also be set to platforms.all

platforms = platforms.unix;

[yasunori0418]

@jopejoe1

Thank you for your review.
I think platforms.unix is better because sheldon has binary releases for linux and mac.
I will try building again with this fix.

[eclairevoyant]

There's no reason to artificially restrict the platforms, IMO it should stay unset and use the defaults from the rust builder.

[jopejoe1]

Interesting, did not know that the rust builder sets them by default.

[jopejoe1]

@yasunori0418 We must ask the maintainers if they can maintain darwin. If not, you can help with this.

Increasing platform availability should not be hold back by a maintainer not being able to support it, if it does not increase maintenance burden by too much, which this pr is definitely not.

[Bot-wxt1221]

@jopejoe1 It is not the reason why we don't merge this PR. However, it is better if someone test app on darwin every time. ofborg only reports whether it builds successfully.

[yasunori0418]

Result of nixpkgs-review pr 339149 run on x86_64-darwin 1

1 package built:

• sheldon

[jopejoe1]

Of course, it's always better to tested for as many platforms as possible, but it's definitely not a requirement that updates need to be tested for all platforms or that the there needs to be a maintainer to all supported platforms.

[yasunori0418]

Result of nixpkgs-review pr 339149 run on x86_64-darwin 1

1 package built:

• sheldon

[yasunori0418]

#339149 (comment)

Platforms should still be set and to include darwin and other unix systems platforms.unix or to inclide non unix systems could also be set to platforms.all

Based on the above comment, I tried changing platforms = platforms.unix with commit 2433b4f.
And the build with this fix appears to be working normally.
-> #339149 (comment)

[Bot-wxt1221]

Wait for nixpkgs committer.

[natsukium]

Please squash your commits.

stale

[emilazy]

This program looks specific to Unix shells (it is a shell plugin manager that supports Bash and Zsh), so it should probably be lib.platforms.unix rather than lib.platforms.all. (Sorry, didn’t realize this had already been done…)

@yasunori0418 We must ask the maintainers if they can maintain darwin. If not, you can help with this.

If it breaks on Darwin and pinging @NixOS/darwin-maintainers doesn’t get it fixed quickly, setting broken = stdenv.isDarwin; is more accurate than leaving it out of platforms.

[natsukium]

I agree with @eclairevoyant 's comment and suggest removing meta.platforms, but I don't think it's wrong to specify platforms.unix explicitly, since this package targets unix shells, as @emilazy said.
In any case, I don't think this is a blocker, so I'll merge it.

Thanks for your contribution! Welcome to nixpkgs🎉