(Translated by https://www.hiragana.jp/)
idris2Packages.idris2Lsp: fix cross eval by SFrijters · Pull Request #339737 · NixOS/nixpkgs · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idris2Packages.idris2Lsp: fix cross eval #339737

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

SFrijters
Copy link
Member

Description of changes

Fix error: makeWrapper/makeShellWrapper must be in nativeBuildInputs. during cross eval. Some dependencies won't build so this doesn't fix the actual build completely but it's a small improvement nonetheless.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 5, 2024
Copy link
Contributor

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattpolzin
Copy link
Contributor

Actually, do you mind updating the PR title and commit message to reflect the package in question living at idris2Packages.idris2Lsp relative to the top level rather than idris2-lsp?

@SFrijters SFrijters changed the title idris2-lsp: fix cross eval idris2Packages.idris2-lsp: fix cross eval Sep 5, 2024
@SFrijters
Copy link
Member Author

Done!

@mattpolzin
Copy link
Contributor

Thanks, but the name is still off; should be idris2Lsp rather than idris2-lsp.

@SFrijters SFrijters changed the title idris2Packages.idris2-lsp: fix cross eval idris2Packages.idris2Lsp: fix cross eval Sep 5, 2024
@SFrijters
Copy link
Member Author

Reading is hard :(

@ofborg ofborg bot requested a review from mattpolzin September 5, 2024 16:11
@mattpolzin mattpolzin merged commit 999e5e3 into NixOS:master Sep 5, 2024
27 of 29 checks passed
@SFrijters SFrijters deleted the idris2-lsp-fix-cross branch September 5, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants