(Translated by https://www.hiragana.jp/)
unrar-free: fix meta.mainProgram by t4ccer · Pull Request #339905 · NixOS/nixpkgs · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unrar-free: fix meta.mainProgram #339905

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

t4ccer
Copy link
Member

@t4ccer t4ccer commented Sep 5, 2024

Description of changes

Set meta.mainProgram to unrar-free instead of previous unrar. It's minor but without it nix run nixpkgs#unrar-free doesn't work as unrar binary does not exist

$ nix-build -A unrar-free && ls ./result/bin
/nix/store/pzfap29ivv4mxnpqmhf6dyl48yqk5hz0-unrar-free-0.3.0
unrar-free

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@thiagokokada
Copy link
Contributor

I am still really disappointed that this is not a drop-in replacement for unrar.

@thiagokokada thiagokokada merged commit 4390614 into NixOS:master Sep 5, 2024
8 of 9 checks passed
@t4ccer t4ccer deleted the t4/unrar-free/fix-main-program branch September 5, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants