(Translated by https://www.hiragana.jp/)
UUV switch for varying actuator dofs by DanielDuecker · Pull Request #16690 · PX4/PX4-Autopilot · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUV switch for varying actuator dofs #16690

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DanielDuecker
Copy link
Contributor

Describe problem solved by this pull request
There is currently just a single vehicle_type uuv for all underwater vehicles. However, depending on the number of actuated DOF different configurations need to be used. Eg. HippoCampus UUV is underactuated and has 4 DOF while the BlueRov2 Heavy has 6 actuated DOF

Describe your solution
this PR introduces a new parameter UUV_DOF_ACTUATED to select different configurations. As a first step it starts the uuv_pos_controller which is proposed in PR #16688 .

Describe possible alternatives
We could also go for multiple uuv vechicle_types e.g. uuv_4dof and uuv_6dof. However, this increases complexity while decreasing the idea of generalized modules

Test data / coverage
So far Gazebo only.

control modules depending on the actuator config
required when HippoCampus (4DOF) and BlueRov (6DOF) shall use the same
control modules.
so far uuv_pos_control will only be used by the BlueROV
control modules depending on the actuator config
required when HippoCampus (4DOF) and BlueRov (6DOF) shall use the same
control modules.
so far uuv_pos_control will only be used by the BlueROV
…ielDuecker/PX4-Autopilot into uuv_switch_for_varying_actuator_dofs
@Jaeyoung-Lim Jaeyoung-Lim added the UUV Unmanned Underwater Vehicle label Jan 29, 2021
#
if [ $UUV_DOF_ACTUATED = 6 ]
then
uuv_pos_control start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the position control module not started when the it is not fully actuated(DOF 6)? Wouldn't it be better to also be able to control position for underactuated UUVs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuv_pos_control does not feature support for the 4dof yet.
will be one of the next steps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielDuecker Yes, but if this is the plan, what I meant was that it would be better if we can handle this from inside the module, rather than preventing the whole app from starting.

@@ -28,4 +28,7 @@ fi
set MAV_TYPE 12
param set MAV_TYPE ${MAV_TYPE}

# set number of actuated degrees of freedom
set UUV_DOF_ACTUATED 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this does not belong to the $AUTOCONF=yes condition?

@Jaeyoung-Lim
Copy link
Member

@DanielDuecker Any updates?

@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale UUV Unmanned Underwater Vehicle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants