Don't close own assets [VPNAND-631].

Also cancel the mapping loop in getInstalledInternetApps when the
coroutine is canceled.

app/src/main/java/com/protonvpn/android/ui/splittunneling/AppsDialog.kt

@@ -20,6 +20,7 @@ package com.protonvpn.android.ui.splittunneling
 
 import android.Manifest
 import android.app.ActivityManager
+import android.content.Context
 import android.content.pm.ApplicationInfo
 import android.content.pm.PackageManager
 import android.content.res.Resources
@@ -41,6 +42,7 @@ import com.protonvpn.android.components.ContentLayout
 import com.protonvpn.android.models.config.UserData
 import com.protonvpn.android.utils.sortedByLocaleAware
 import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.ensureActive
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import javax.inject.Inject
@@ -79,7 +81,7 @@ class AppsDialog : BaseDialog() {
 
         val selection = userData.splitTunnelApps.toSet()
         viewLifecycleOwner.lifecycleScope.launch {
-            val allApps = getInstalledInternetApps(requireContext().packageManager)
+            val allApps = getInstalledInternetApps(requireContext().applicationContext)
             val sortedApps = withContext(Dispatchers.Default) {
                 allApps.forEach { app ->
                     if (selection.contains(app.packageName)) {
@@ -109,28 +111,36 @@ class AppsDialog : BaseDialog() {
             .forEach { userData.removeAppFromSplitTunnel(it) }
     }
 
+    // Pass app context to avoid problems when the dialog is closed and the IO thread is still
+    // accessing the PackageManager.
     private suspend fun getInstalledInternetApps(
-        packageManager: PackageManager
+        appContext: Context
     ): List<SelectedApplicationEntry> = withContext(Dispatchers.IO) {
+        val packageManager = appContext.packageManager
+        val ourPackageName = appContext.packageName
         val apps = packageManager.getInstalledApplications(
             0
         ).filter { appInfo ->
             (packageManager.checkPermission(Manifest.permission.INTERNET, appInfo.packageName)
                     == PackageManager.PERMISSION_GRANTED)
         }.map { appInfo ->
-            getAppMetadata(packageManager, appInfo)
+            ensureActive()
+            getAppMetadata(packageManager, appInfo, ourPackageName)
         }
         apps
     }
 
     private fun getAppMetadata(
         packageManager: PackageManager,
-        appInfo: ApplicationInfo
+        appInfo: ApplicationInfo,
+        ourPackageName: String
     ): SelectedApplicationEntry {
         val appResources = packageManager.getResourcesForApplication(appInfo)
         val label = getLabel(appResources, appInfo.labelRes) ?: appInfo.packageName
         val icon = getIcon(appResources, appInfo.icon) ?: packageManager.defaultActivityIcon
-        appResources.assets.close()
+        if (appInfo.packageName != ourPackageName) {
+            appResources.assets.close()
+        }
         return SelectedApplicationEntry(appInfo.packageName, label.toString(), icon)
     }