(Translated by https://www.hiragana.jp/)
Harmonize label format and tick resolution choosing logic by spencerkclark · Pull Request #79 · SciTools/nc-time-axis · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize label format and tick resolution choosing logic #79

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

spencerkclark
Copy link
Member

🚀 Pull Request

This takes a fairly simple approach to addressing #48. Here I define a mapping between the resolution chosen by the tick locator depending on the range and number of ticks requested, and the date format for the labels on the axis.

The plot @klindsay28's example now produces is shown below:

result

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #79 (63c53f7) into main (f42e64a) will increase coverage by 1.38%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   89.20%   90.58%   +1.38%     
==========================================
  Files           1        1              
  Lines         176      170       -6     
  Branches       43       41       -2     
==========================================
- Hits          157      154       -3     
+ Misses         13       11       -2     
+ Partials        6        5       -1     
Impacted Files Coverage Δでるた
nc_time_axis/__init__.py 90.58% <80.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δでるた = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42e64a...63c53f7. Read the comment docs.

Copy link
Contributor

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and more coherent! I see the potential issue with using a maybe-unset attribute from the other class, but let's leave that for another PR, when the issue comes up!

@spencerkclark
Copy link
Member Author

Thanks @aulemahal -- in it goes!

@spencerkclark spencerkclark merged commit 59c567d into SciTools:main Aug 10, 2021
@spencerkclark spencerkclark deleted the harmonize-labels branch August 10, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants