(Translated by https://www.hiragana.jp/)
Modifying `fqdn` in an existing TunnelBinding does not clean up DNS records · Issue #70 · adyanth/cloudflare-operator · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying fqdn in an existing TunnelBinding does not clean up DNS records #70

Open
Quantum64 opened this issue Dec 18, 2022 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Quantum64
Copy link

DNS deletion is only executed in the finalizer.

@adyanth adyanth self-assigned this Dec 19, 2022
@adyanth
Copy link
Owner

adyanth commented Dec 19, 2022

Yes, that is correct. I could not think of a way to do that since the operator does not receive the diff of what has been modified.

We could check the current config and look at what changed, or mark the DNS entries with some unique operator ID and clean up everything when the binding is deleted, but I did not feel that was the most optimal solution. I will keep this issue open to track and find a proper solution. Do let me know if you have any ideas.

@Quantum64
Copy link
Author

Given the flakey behavior and the ability to proxy star records, I would definitely prefer to disable Cloudflare API integration completely. The ability to programmatically manage the cloudflared configuration via CRDs is still very useful for us. Is there a timeline for #57?

@adyanth
Copy link
Owner

adyanth commented Dec 19, 2022

That is a good approach. I will work on that, should be done soon and straightforward to complete that as a conditional check before calling the APIs.

@adyanth adyanth pinned this issue Dec 20, 2022
@adyanth adyanth added the help wanted Extra attention is needed label Dec 20, 2022
@adyanth
Copy link
Owner

adyanth commented Dec 21, 2022

@Quantum64 #71 is merged, fixing #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants