This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Feature/ability to build static and shared #1854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2020 00:50
…h linking now). Signed-off-by: Alexander Ismailov <alexismailov2@gmail.com>
…ly libraries. Signed-off-by: Alexander Ismailov <alexismailov2@gmail.com>
|
Thank you for the pull request. Our process is to make changes internally and run all test before pushing the change to github in the form of a new release. I have added this to our internal tracking system to be assessed and prioritized. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in ability to build this project as a bunch of static libraries, and ability to switch off building SampleApp application(for example when libraries only needed).
Added a global option "BUILD_STATIC_LIBS" and in addition "BUILD_SAMPLE_APP" in the SampleApp/CMakeLists.txt.
It can be used by passing this options to cmake on generation stage.
For example this parameters will produce build system with static library building only and without SampleApp executable.
-DBUILD_STATIC_LIBS=ON
-DBUILD_SAMPLE_APP=OFF
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.