(Translated by https://www.hiragana.jp/)
feat(filter): add no selected elements display for itme-filter by Runtus · Pull Request #6374 · antvis/G2 · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filter): add no selected elements display for itme-filter #6374

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat(filter): add no selected elements display for itme-filter #6374

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8a095b
feat: add no elements display for filter
Runtus Jul 22, 2024
bd61214
fix: remove desc
Runtus Jul 22, 2024
5e0b3c9
fix: lint
Runtus Jul 23, 2024
a09a053
fix: fix lint
Runtus Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove desc
  • Loading branch information
@Runtus
Runtus committed Jul 22, 2024
commit bd612144798c9a72a7dd952f8dce1e9be05451e1
1 change: 0 additions & 1 deletion src/transform/filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export const Filter: TC<FilterOptions> = (options = {}) => {
const FI = I.filter(totalFilter);
const newIndex = FI.map((_, i) => i);

// Skip empty filters.
if (filters.length === 0) {
const targetMark = filterWhenNoElements(mark);
pearmini marked this conversation as resolved.
Show resolved Hide resolved
return [I, targetMark];
Expand Down
Loading