(Translated by https://www.hiragana.jp/)
PHOENIX-7239: Fix issues when data and index have different salt buckets by haridsv · Pull Request #1969 · apache/phoenix · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7239: Fix issues when data and index have different salt buckets #1969

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haridsv
Copy link
Contributor

@haridsv haridsv commented Sep 3, 2024

This PR includes the following changes:

  • Currently IndexMaintainer assumes that both data and index tables have the same number of salt buckets. This change adds a separate field for data table and uses it for constructing the data keys. This fixes the joins between uncovered index and data tables.
  • There is a typo in the CDC mutation code path that uses data table to construct the index row key instead of the index table which was throwing off the logic that join the changes to the data rows.
  • Test for time range queries has been rewritten to be simpler and also add coverage for the above special DF markers.
  • Some of the existing debug code in the CDC IT test has been refactored to be less repetitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant