[Draft][FFI] Remove backwards-compatibility unwrapping of IntImm #17241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The initial commit in this PR branch only removes the backwards-compatibility handler, and does not yet update any callers. This is expected to trigger breakage in CI, which will identify the callers that must be updated. |
Lunderberg
changed the title
Lunderberg
force-pushed
the
ffi_remove_automatic_intimm_to_runtime_int_conversion
branch
from
a721e35
to
cf1b599
Compare
|
would be great to followup on this one |
|
Agreed, though unfortunately I haven't had time to do so. It looks like the current failures are in the relay/collage C++ testing, but I haven't looking into it. |
|
Given these are legacy. I think we can remove those tests to move forward |
This is a follow-up PR to apache#16183, which updated the FFI with explicit integer types. As part of that change, many internal functions were updated to accept non-IR types (e.g. `Array<runtime::Int>` instead of `Array<IntImm>`). For backwards compatibility with callees that provided the IR types, a specialization of `PackedFuncValueConverter` unwrapped the `IntImm` into a `runtime::Int`. This commit removes the backwards-compatibility specialization of `PackedFuncValueConverter`. Breakages that are found in CI as a result will then be updated at the caller side, removing the need for the backwards-compatibility handler altogether.
Lunderberg
force-pushed
the
ffi_remove_automatic_intimm_to_runtime_int_conversion
branch
from
cf1b599
to
2e187d7
Compare
|
would be great to check the remaining errors and get this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #16183, which updated the FFI with explicit integer types. As part of that change, many internal functions were updated to accept non-IR types (e.g.
Array<runtime::Int>instead ofArray<IntImm>). For backwards compatibility with callees that provided the IR types, a specialization ofPackedFuncValueConverterunwrapped theIntImminto aruntime::Int.This commit removes the backwards-compatibility specialization of
PackedFuncValueConverter. Breakages that are found in CI as a result will then be updated at the caller side, removing the need for the backwards-compatibility handler altogether.