Avoid resolving paths on fragments #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bioball
approved these changes
Mar 22, 2024
bioball
force-pushed
the
pholzenspies/docPackageUriFix
branch
from
fea0f00
to
bfb053f
Compare
bioball
pushed a commit
that referenced
this pull request
Mar 26, 2024
Fixes an issue where modules with fragment paths are resolved against the URI path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more principled solution is to have
importUribe aURIinstead of aStringand to test its scheme.Generally, the problem is that
URI::resolvecan not assume fragments to be a path (and that it discards fragments altogether).