(Translated by https://www.hiragana.jp/)
Support `_` in String[toInt|toIntOrNull|toFloat|toFloatOrNull] by stackoverflow · Pull Request #580 · apple/pkl · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support _ in String[toInt|toIntOrNull|toFloat|toFloatOrNull] #580

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

stackoverflow
Copy link
Contributor

The logic is the same as the Pkl parser

The logic is the same as the Pkl parser
Copy link
Contributor

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stackoverflow stackoverflow merged commit 24cc95a into apple:main Jul 16, 2024
5 checks passed
@stackoverflow stackoverflow deleted the to-float-accept_ branch July 16, 2024 17:25
taichi-ishitani added a commit to taichi-ishitani/rupkl that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants