Fix property parsing bug in the cli #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is that a bug? 🤔 |
Because before this fix you couldn't set a property to empty string.
Why would this be an error? Empty string is a valid property value. |
|
Got it. I misunderstood the implementation 😂 |
holzensp
approved these changes
Jul 24, 2024
pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt
Outdated
Show resolved
Hide resolved
| @@ -45,10 +45,10 @@ class BaseCommandTest { | |||
|
|
|||
| @Test | |||
| fun `external properties without value default to 'true'`() { | |||
| cmd.parse(arrayOf("-p", "flag1", "-p", "flag2", "-p", "FOO=bar")) | |||
| cmd.parse(arrayOf("-p", "flag1", "-p", "flag2=", "-p", "FOO=bar")) | |||
There was a problem hiding this comment.
The flag1 and flag2 test cases becoming overlapped should have been a hint before ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a property set as
-p foo=would be parsed as"true"instead of"".