Gh-2840: MapStore MatchedVertex inconsistent #3297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cn337131
changed the title
cn337131
changed the title
cn337131
added
bug
p29876
reviewed
Sep 17, 2024
Comment on lines
544
to
545
| assertThat(new String(JSONSerialiser.serialise(list.get(0), true))).isEqualTo(EXPECTED); | ||
| assertThat(new String(JSONSerialiser.serialise(list.get(0), true))).doesNotContain("matchedVertex"); |
There was a problem hiding this comment.
It might be easier here to do the comparison as Element/Edge objects rather than the string representation
p29876
reviewed
Sep 17, 2024
core/operation/src/main/java/uk/gov/gchq/gaffer/operation/data/EdgeSeed.java
Show resolved
Hide resolved
p29876
reviewed
Sep 17, 2024
...lementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/AddElementsHandler.java
Show resolved
Hide resolved
tb06904
reviewed
Sep 17, 2024
...lementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/AddElementsHandler.java
Show resolved
Hide resolved
...tion/map-store/src/test/java/uk/gov/gchq/gaffer/mapstore/impl/GetAllElementsHandlerTest.java
Outdated
Show resolved
Hide resolved
...tion/map-store/src/test/java/uk/gov/gchq/gaffer/mapstore/impl/GetAllElementsHandlerTest.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue