[scapy] poke Packet.summary() #12050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's kind of a follow-up to secdev/scapy#4381 ans should help to catch issues like that going forward.
|
evverx has previously contributed to projects/scapy. The previous PR was #11912 |
|
This looks good to me! The fuzzing harness in Scapy is indeed a great idea. |
DavidKorczynski
approved these changes
Jun 13, 2024
|
@jonathanmetzman @DavidKorczynski I'm planning to move it next week probably but I wonder if it would be OK if it was relicensed? It was created by a bot apparently so I don't know who can approve that. |
evverx
added a commit
to evverx/oss-fuzz
that referenced
this pull request
Jun 23, 2024
as discussed in google#12050
evverx
added a commit
to evverx/scapy
that referenced
this pull request
Jun 23, 2024
as discussed in google/oss-fuzz#12050
evverx
added a commit
to evverx/scapy
that referenced
this pull request
Jun 23, 2024
as discussed in google/oss-fuzz#12050
evverx
added a commit
to evverx/scapy
that referenced
this pull request
Jul 2, 2024
as discussed in google/oss-fuzz#12050
evverx
added a commit
to evverx/scapy
that referenced
this pull request
Aug 1, 2024
as discussed in google/oss-fuzz#12050
evverx
added a commit
to evverx/scapy
that referenced
this pull request
Aug 1, 2024
as discussed in google/oss-fuzz#12050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kind of a follow-up to secdev/scapy#4381 ans should help to catch issues like that going forward.
@gpotter2 @guedou @p-l- could you take a look?
(I think ideally it would be nice to move the fuzz target to the scapy repository where it could be changed and reviewed without having to open PRs here)