(Translated by https://www.hiragana.jp/)
Refactor the library to allow database-specific extensions · Issue #59 · grafana/xk6-sql · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the library to allow database-specific extensions #59

Closed
andrewslotin opened this issue Mar 19, 2024 · 1 comment
Closed

Refactor the library to allow database-specific extensions #59

andrewslotin opened this issue Mar 19, 2024 · 1 comment

Comments

@andrewslotin
Copy link
Contributor

The current architecture of the extension requires adding each database driver as a dependency, which does not scale well, as adding support for a new database creates the demand for keeping its driver up-to-date and increases the risk of introducing vulnerabilities to the extension code. Adding the db driver as a dependency is needed to make the sql.Open() work due to the design of Go's stdlib package.

As an alternative solution we propose to redesign the API of this extension to allow users to use it as a base for database-specific extensions that can be used depending on the use-case.

@szkiba
Copy link
Contributor

szkiba commented Oct 14, 2024

Modularization takes into account and at the same time makes this issue obsolete.

@szkiba szkiba closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants