Migrate to GitHub Actions #75
Conversation
* Move from CircleCI to GitHub Actions * Add release action that can be manually triggered which create a tag and the release. With that in place, we will no longer have to create and push tags locally in order to trigger the release build * Add Mage so all required steps can be run locally and in the GitHub workflow * Add golangci-lint and a check for missing license headers Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
| @@ -54,9 +50,8 @@ func (p *Packager) CreatePackages() error { | |||
| if _, err := os.Stat(p.paths[i]); err != nil { | |||
| return err | |||
| } | |||
| deepcopier.Copy(p.config).To(settings) | |||
There was a problem hiding this comment.
I removed that. The linter complained because the error is not checked. I found out that it always returned an error. So I removed it. It was completely unnecessary as the settings parameter is not used by the Run method.
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
unguiculus
force-pushed
the
feature/actions
branch
from
91abff1
to
9c2d1c0
Compare
|
For some reason, running |
|
In order to trigger the workflow before merging to master I created a PR against this branch in my fork: |
|
It looks OK now, yes? I tested go mod tidy in the same container that circle used to test with |
|
I see, you updated https://github.com/unguiculus/chart-releaser/pull/1/commits |
and the release. With that in place, we will no longer have to create
and push tags locally in order to trigger the release build
workflow
Signed-off-by: Reinhard Nägele unguiculus@gmail.com