Added deviceId parameter to the scene - it will set what camera to us… #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e based on its deviceId
What kind of change does this PR introduce?
This is a new feature - allows to define the deviceId to use for the camera.
** Can it be referenced to an Issue? If so what is the issue # ?**
Might be useful for this issue : #178
How can we test it?
You can use this feature by defining the deviceid as a parameter in the scene, like this :
<a-scene embedded arjs="detectionMode: mono_and_matrix; matrixCodeType: 3x3; sourceType: webcam; trackingMethod: best; debugUIEnabled: false; deviceId: 10d9f755ccab290ef5dbd4a1bb27cca11e61677ab0b4356f302e098ef6144813;" antialias="true">
In order to get the deviceId, you can use getUserMedia.
Summary
Does this PR introduce a breaking change?
It doesn't. The previous behaviour to select what camera to pick up is the default one. The deviceId parameter is optional.
Other information