Add flakey Date.prototype.getDay and Object.keys #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keidyz
reviewed
Jul 22, 2024
| const clonedNow = Date.now | ||
| const clonedGetDay = Date.prototype.getDate |
There was a problem hiding this comment.
Suggested change
| const clonedGetDay = Date.prototype.getDate | |
| const clonedGetDay = Date.prototype.getDay |
Comment on lines
+16
to
+24
| let incorrectDay = clonedMathFloor(clonedMathRandom() * 7) | ||
|
|
||
| // Math.random() could theoretically return 1, which would make incorrectDay 7 | ||
| // 7 is not a valid day of the week, so we need to change it to 6 | ||
| if (incorrectDay === 7) { | ||
| incorrectDay = 6 | ||
| } | ||
|
|
||
| return incorrectDay |
There was a problem hiding this comment.
Suggested change
| let incorrectDay = clonedMathFloor(clonedMathRandom() * 7) | |
| // Math.random() could theoretically return 1, which would make incorrectDay 7 | |
| // 7 is not a valid day of the week, so we need to change it to 6 | |
| if (incorrectDay === 7) { | |
| incorrectDay = 6 | |
| } | |
| return incorrectDay | |
| return Math.min(clonedMathFloor(clonedMathRandom() * 7), 6) |
| Object.keys = function (obj: object): string[] { | ||
| let keys = clonedKeys.call(this, obj); | ||
|
|
||
| if (clonedMathRandom() < 0.5) { |
There was a problem hiding this comment.
let's shuffle based on generatePercentChanceToFlake.
This is so when someone makes PERCENT_CHANCE_OF_SUCCESS 100, they can completely disable all possible weirdness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I
hatelove JS! <3Therefore, I wanted to add more flakeyness and support you on the great journey to make JS more
flakeyawesome.See below my implementation for Date.prototype.getDay and Object.keys.
I espacially love the Object.keys implementation, it adds some real spice to JS. The shuffling is tricky as you could rely on it but I love that, under very rare circumstances (2% of flakey-cases), you actually get "flaked"!
Have a really great day! :)