[PrepareForEmission] Hoist registers in a procedural region with disallowLocalVariables
#7404
Conversation
…allowLocalVariables` Fix #7399
uenoku
force-pushed
the
dev/hidetou/fix-reg
branch
from
b882e39
to
63c162f
Compare
|
The diff is very small and it fixes the crash reported so I'm going to merge it. |
uenoku
changed the title
disallowLocalVariables
|
LGTM, sorry I got lost chasing down whether this was "correct" if it had an initializer and checking consistent handling other places specific to LogicOp (or RegOp). LogicOp doesn't have this concern since it doesn't support an initializer. The initialization is a one-time thing so I was thinking that pulling that out of a procedural block could change when that occurs (including how many times?). Not sure that's the case, got pulled into other things before chasing down more thoroughly. WDYT? While pushing on that I ran into a bug I filed as #7405 , that isn't what I describe above but something breaks def-before-use. |
|
Thank you for pointing this out! I was slightly surprised that reg op initial operand is not restricted to constant. I think for RegOp with initial operand under disallowLocalVariables, PrepareForEmission should drop initialization operand in reg op declaration but create sv.bpassign in the original position. WDYT? |
Fix #7399