[CMake] Fix install failure with CMAKE_SLANG_FRONTEND_ENABLED enabled #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slang compiler relies on the third-party libraries like unordered_dense and fmt library. The fmt library provides two ways to integrated it: 1.Headers-only 2.Seperately compiled The main purpose of this commit is to avoid installation failure of CIRCT project due to finding fmt header file in wrong path which is in circt `include` directory when CMake_slang_Frontend_enabled is turned on. We hope to not install header files coming from fmt library.
|
This problem is mentioned previously in #7188 |
fabianschuiki
approved these changes
Aug 5, 2024
Okay! I ‘ll add it😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slang compiler relies on the third-party libraries like unordered_dense and fmt library. The fmt library provides two ways to integrated it:
1.Headers-only
2.Seperately compiled
The main purpose of this commit is to avoid installation failure of CIRCT project due to finding fmt header file in wrong path which is in circt
includedirectory when CMake_slang_Frontend_enabled is turned on. We hope to not install header files coming from fmt library.