(Translated by https://www.hiragana.jp/)
[Docs][FIRRTL] Build and include docs for intrinsic ops by SpriteOvO · Pull Request #7444 · llvm/circt · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][FIRRTL] Build and include docs for intrinsic ops #7444

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

SpriteOvO
Copy link
Member

Fixes #7443.

@SpriteOvO SpriteOvO added documentation Improvements or additions to documentation FIRRTL Involving the `firrtl` dialect labels Aug 5, 2024
@dtzSiFive
Copy link
Contributor

Thanks for the PR!!

Change LGTM from phone, haven't tried it to double-check but seems right to me!

Probably we should move more intrinsics into this section / file but that's not for this PR, just a detail now that we have this nicely integrated into the generated docs 😁.

@SpriteOvO
Copy link
Member Author

Thank @dtzSiFive for reviewing! I'm not sure how to invoke Hugo, so I didn't check HTML. At least in ./build/docs/Dialects/FIRRTLIntrinsicOps.md I see the missing ops appearing.

@SpriteOvO SpriteOvO merged commit b35bc81 into llvm:main Aug 6, 2024
4 checks passed
@SpriteOvO SpriteOvO deleted the firrtl-fix-int-ops-doc branch August 6, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs][FIRRTL] Missing intrinsic ops docs
2 participants