(Translated by https://www.hiragana.jp/)
[SimToSV] Add include guards to DPI import by uenoku · Pull Request #7459 · llvm/circt · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SimToSV] Add include guards to DPI import #7459

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Aug 7, 2024

This adds include guards __CIRCT_DPI_IMPORT_* to DPI import statements generated in SimToSV.

Fix #7458.

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It's pretty convenient that the sv.func.dpi.import op is just a marker that points at a function declaration somewhere else. Moving the actual function with the actual @... symbol name into would probably have been a lot more annoying, right?

@uenoku
Copy link
Member Author

uenoku commented Aug 8, 2024

Moving the actual function with the actual @... symbol name into would probably have been a lot more annoying, right?

Yes the function declaration must be a child of SymbolTable op and we cannot nest that.

@uenoku uenoku merged commit 12822ad into main Aug 8, 2024
4 checks passed
@uenoku uenoku deleted the dev/hidetou/add-include-guards branch August 8, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SimToSV] Add includes guard to SV import
2 participants