[CreateSifiveMetadata] Update memory hierarchy paths to be pre-extrction #7491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
reviewed
Aug 9, 2024
prithayan
force-pushed
the
dev/pbarua/memory-metadata
branch
from
bc5f51e
to
29b0678
Compare
mikeurbach
approved these changes
Aug 10, 2024
prithayan
force-pushed
the
dev/pbarua/memory-metadata
branch
from
29b0678
to
6c5dfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CreateSifiveMetadatapass was creating hierarchy paths to the memory module pre-extraction.The
om.pathwas being updated as the memory was extracted in the following passes.But recently we realized this was a bug, as the downstream tools consuming the metadata files, were actually expecting the pre-extraction hierarchy paths to the memory.
So, this PR fixes the path to terminate at the parent of the module that instantiates the memory and encodes the pre-extraction memory instance as a string.
The tool that will parse the final
mlirmust now construct the actual pre-extraction path from the two lists, by appending the pre-extraction instance name to the path.