[CIR][DirectToLLVM][NFC] Add include of target lowering library to DirectToLLVM #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Jul 17, 2024
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…rectToLLVM (llvm#745) TargetLowering should also serve for DirectToLLVM for target-specific information. The library is already linked against DirectToLLVM, but we have to write dirty includes like `#include "../../Dialect/Transforms/TargetLowering/LowerModule.h"`. This PR adds a private include directory `clang/lib/CIR/Dialect/Transforms/TargetLowering` to the target DirectToLLVM. Then we can simplify the include directive above to `#include "LowerModule.h"`.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…rectToLLVM (llvm#745) TargetLowering should also serve for DirectToLLVM for target-specific information. The library is already linked against DirectToLLVM, but we have to write dirty includes like `#include "../../Dialect/Transforms/TargetLowering/LowerModule.h"`. This PR adds a private include directory `clang/lib/CIR/Dialect/Transforms/TargetLowering` to the target DirectToLLVM. Then we can simplify the include directive above to `#include "LowerModule.h"`.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…rectToLLVM (llvm#745) TargetLowering should also serve for DirectToLLVM for target-specific information. The library is already linked against DirectToLLVM, but we have to write dirty includes like `#include "../../Dialect/Transforms/TargetLowering/LowerModule.h"`. This PR adds a private include directory `clang/lib/CIR/Dialect/Transforms/TargetLowering` to the target DirectToLLVM. Then we can simplify the include directive above to `#include "LowerModule.h"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TargetLowering should also serve for DirectToLLVM for target-specific information. The library is already linked against DirectToLLVM, but we have to write dirty includes like
#include "../../Dialect/Transforms/TargetLowering/LowerModule.h".This PR adds a private include directory
clang/lib/CIR/Dialect/Transforms/TargetLoweringto the target DirectToLLVM. Then we can simplify the include directive above to#include "LowerModule.h".