-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(WebGL): convert HTML tables to Markdown #36073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
Web API docs
size/xl
[PR only] >1000 LoC changed
labels
Sep 27, 2024
Preview URLs (comment last updated: 2024-09-27 09:43:45) |
caugner
force-pushed
the
convert-webgl-constant-tables-to-md
branch
from
September 27, 2024 07:58
04e6292
to
386938a
Compare
caugner
commented
Sep 27, 2024
Here's a diff, comparing the pretty-printed |
caugner
requested review from
sideshowbarker
and removed request for
a team
September 27, 2024 08:17
caugner
commented
Sep 27, 2024
bsmth
reviewed
Sep 27, 2024
bsmth
reviewed
Sep 27, 2024
bsmth
reviewed
Sep 27, 2024
bsmth
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor suggestions, tnx 👍🏻
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts verbose HTML tables to Markdown.
Motivation
This page is causing trouble during machine translation due to its length, and converting the tables should help.
Additional details
Related issues and pull requests