(Translated by https://www.hiragana.jp/)
refactor(WebGL): convert HTML tables to Markdown by caugner · Pull Request #36073 · mdn/content · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(WebGL): convert HTML tables to Markdown #36073

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 27, 2024

Description

Converts verbose HTML tables to Markdown.

Motivation

This page is causing trouble during machine translation due to its length, and converting the tables should help.

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:WebAPI Web API docs size/xl [PR only] >1000 LoC changed labels Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

Preview URLs

(comment last updated: 2024-09-27 09:43:45)

@caugner caugner force-pushed the convert-webgl-constant-tables-to-md branch from 04e6292 to 386938a Compare September 27, 2024 07:58
@caugner
Copy link
Contributor Author

caugner commented Sep 27, 2024

Here's a diff, comparing the pretty-printed innerHTML of the rendered article element, between production and the PR preview:

https://www.diffchecker.com/S6Di7N33/

@caugner caugner marked this pull request as ready for review September 27, 2024 08:17
@caugner caugner requested a review from a team as a code owner September 27, 2024 08:17
@caugner caugner requested review from sideshowbarker and removed request for a team September 27, 2024 08:17
@bsmth bsmth self-requested a review September 27, 2024 09:26
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor suggestions, tnx 👍🏻

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@caugner caugner merged commit 8ac0afb into main Sep 27, 2024
9 checks passed
@caugner caugner deleted the convert-webgl-constant-tables-to-md branch September 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants