(Translated by https://www.hiragana.jp/)
make bullets looks better by shifting punctuation towards right by Cecil0o0 · Pull Request #36141 · mdn/content · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bullets looks better by shifting punctuation towards right #36141

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Cecil0o0
Copy link
Contributor

@Cecil0o0 Cecil0o0 commented Oct 1, 2024

Description

It seems like a tiny mistake about usage of punctuation, although actually I could still understand the means of this sentence.

Motivation

When I see the sentence above this one, which is

Updating code styling just because "you like that style better".

the first impression is that the sentence that is quoted may be imagined as a chat item in a chat room. It's general for people like me.

but

Updating language style "just because you like that style better"

makes me a little bit confused becaue of the shifts towards left of the " punctuation in almost same two sentences.

Additional details

Related issues and pull requests

@Cecil0o0 Cecil0o0 requested a review from a team as a code owner October 1, 2024 07:15
@Cecil0o0 Cecil0o0 requested review from hamishwillee and removed request for a team October 1, 2024 07:15
@github-actions github-actions bot added Content:Meta Content in the meta docs size/xs [PR only] 0-5 LoC changed labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cecil0o0 Thank you. I agree.

Note though that this is a very minor point - there's no ambiguity here and no one is likely to be confused. In future I am likely to reject this kind of change as unnecessary even if it is technically correct - in line with MDN policy.

The reason for this is that we have a limited number of reviewers and each change like this notifies all of us. This kind of thing is simply not a priority.

@hamishwillee hamishwillee merged commit 9707395 into mdn:main Oct 1, 2024
7 checks passed
@Cecil0o0 Cecil0o0 deleted the fix/typo branch October 1, 2024 08:13
@Cecil0o0
Copy link
Contributor Author

Cecil0o0 commented Oct 1, 2024

@hamishwillee Thanks very much for notes and reasons! I feel comfortable for what you said and done.

The comment above will help me to measure and evaluate whether necessary enough or not before submit next pr.

pepelsbey pushed a commit to pepelsbey/mdn-content that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Meta Content in the meta docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants