JSONDecodeError: AI sometimes produces JSON with a code block format

[FoliageOwO]

🐛 Describe the bug

I was creating a memory, following the official document.

But I did get confused at this error:

json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

which is occurred at the line

new_memories_with_actions = json.loads(new_memories_with_actions)

After checking what on earth are the new_memories_with_actions, I found that the AI did respond a JSON content, but with triple backticks (the code block format), just like this (I'm using diff because the triple backticks will not show at the time):

+ ```json
+ {
+     "memory": [
+         {
+             "id": "(UUID)",
+             "text": "I'm visiting Paris",
+             "event": "ADD"
+         }
+     ]
+ }
+ ```

which surely will get json.loads() crashed.

Is anything wrong?

EDIT:
BTW I think it was the model that caused the issue of generating bad content, so I need to declare that I was using Qwen (the model by Alibaba Cloud), not gpt-4 or gpt-4o or something that was mentioned in the official document.

[FoliageOwO]

I solved this problem by adding these lines in mem0/memory/main.py:

mem0/mem0/memory/main.py

Lines 168 to 173 in f40a2e7

	function_calling_prompt = get_update_memory_messages(retrieved_old_memory, new_retrieved_facts)
	new_memories_with_actions = self.llm.generate_response(
	messages=[{"role": "user", "content": function_calling_prompt}],
	response_format={"type": "json_object"},
	)
	new_memories_with_actions = json.loads(new_memories_with_actions)

  ...
+ import re
  ...
          function_calling_prompt = get_update_memory_messages(retrieved_old_memory, new_retrieved_facts)
          new_memories_with_actions = self.llm.generate_response(
              messages=[{"role": "user", "content": function_calling_prompt}],
              response_format={"type": "json_object"},
          )
    
+         search_result = re.search("(```json)((.*\n)+)(```)", new_memories_with_actions)
+         if search_result:
+             new_memories_with_actions = search_result.group(2).strip()

          new_memories_with_actions = json.loads(new_memories_with_actions)

EDIT:
The issue will not occur only at the json.loads() line I mentioned before, but also here:

mem0/mem0/memory/main.py

Lines 142 to 145 in f40a2e7

	response = self.llm.generate_response(
	messages=[{"role": "system", "content": system_prompt}, {"role": "user", "content": user_prompt}],
	response_format={"type": "json_object"},
	)

[prateekchhikara]

@FoliageOwO can you please raise a PR for this?

[FoliageOwO]

@FoliageOwO can you please raise a PR for this?

@prateekchhikara Hi, I just created a new PR #1860, please review it when you get a second.

[hhhhhge]

@FoliageOwO can you please raise a PR for this?

@prateekchhikara Hi, I just created a new PR #1860, please review it when you get a second.

When will this bug be fixed o(╥﹏╥)o

[FoliageOwO]

@hhhhhge 等ひとし PR 被ひ合ごう并并发布到いた新しん的てき Release 版本はんぽん后きさき，所有しょゆう人じん就都可か以用上うえ了りょう。如果你目前ぜん要よう紧急解かい决这个问题的话，可か以手动克隆たかし我が的てき fork 仓库到 pip 安あん装そう的てき包つつみ的てき目め录，也可以根据すえ我が的てき commit 手て动修改あらため本地ほんじ包つつみ源げん码。目前もくぜん的てき PR 并能代表だいひょう最さい终 Release，我が的てき方案ほうあん可能かのう不ふ是ぜ最さい好このみ的てき，也许可能かのう会かい被ひ其他贡献者しゃ改あらため进，但ただし是ぜ可か以暂时用来らい应急。

For those who can't wait for the PR approval and releasing process: you can clone my fork repository to your pip packages folder, or manually edit local mem0 source codes according to my commit.