-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always fill the mask with the backdrop color #18960
Conversation
It fixes mozilla#18956. In the patch mozilla#18029, for performance reasons and because I thought it was useless, I deliberately chose to not fill the mask with the backdrop color when it's full black: it was a bad idea. So in this patch we always add the backdrop color to the mask.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3bd08743c258ab5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9b2e8aec36167dc/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3bd08743c258ab5/output.txt Total script time: 30.90 mins
Image differences available at: http://54.241.84.105:8877/3bd08743c258ab5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9b2e8aec36167dc/output.txt Total script time: 50.92 mins
Image differences available at: http://54.193.163.58:8877/9b2e8aec36167dc/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5e5b28f2df9b413/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/90a353272ba390c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5e5b28f2df9b413/output.txt Total script time: 20.60 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/90a353272ba390c/output.txt Total script time: 29.24 mins
|
It fixes #18956.
In the patch #18029, for performance reasons and because I thought it was useless, I deliberately chose to not fill the mask with the backdrop color when it's full black: it was a bad idea. So in this patch we always add the backdrop color to the mask.