(Translated by https://www.hiragana.jp/)
Native code for ESPNOW feature by SandorDobos · Pull Request #2218 · nanoframework/nf-interpreter · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native code for ESPNOW feature #2218

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from

Conversation

SandorDobos
Copy link
Contributor

Description

Adds native code supporting nanoFramework.Hardware.Esp32.EspNow managed lib.

Motivation and Context

How Has This Been Tested?

Used in my own project.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot changed the title Native code for ESPNOW feature. Native code for ESPNOW feature Jan 6, 2022
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Jan 6, 2022

@SandorDobos there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click SandorDobos#4, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

SandorDobos and others added 12 commits January 16, 2022 22:50
…/github.com/SandorDobos/nf-interpreter into feature-nanoFramework.Hardware.Esp32.EspNow

# Conflicts:
#	.vscode/cmake-variants-DEVCONTAINER.json
#	.vscode/cmake-variants.TEMPLATE.json
#	build.ps1
Automated fixes for code style.
…683f' of https://github.com/nanoframework/nf-interpreter into nanoframework-nfbot/clang-format-fix/50006557-6649-4026-8a5a-f6d9c090683f
…-8a5a-f6d9c090683f' into feature-nanoFramework.Hardware.Esp32.EspNow
Automated fixes for code style.
…-8a39-2f742586a29b' into feature-nanoFramework.Hardware.Esp32.EspNow
…-95a3-c13d13bb726b' into feature-nanoFramework.Hardware.Esp32.EspNow
@josesimoes josesimoes force-pushed the develop branch 10 times, most recently from 02961e4 to ff3b7cd Compare February 9, 2022 15:06
@@ -16,6 +16,10 @@
// Keep command history
"source=nano-bashhistory,target=/home/vscode/commandhistory,type=volume",
],
"workspaceFolder": "/workspace",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file don't belong to this PR, please revert.

@@ -292,7 +292,8 @@
"API_nanoFramework.Hardware.Esp32.Rmt": "ON",
"API_System.Device.Dac": "ON",
"API_nanoFramework.Graphics": "OFF",
"API_nanoFramework.Device.Bluetooth": "ON"
"API_nanoFramework.Device.Bluetooth": "ON",
"API_nanoFramework.Espnow": "ON"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"API_nanoFramework.Espnow": "ON"
"API_nanoFramework.EspNow": "ON"

@@ -339,7 +340,8 @@
"API_nanoFramework.Hardware.Esp32.Rmt": "ON",
"API_System.Device.Dac": "ON",
"API_nanoFramework.Graphics": "OFF",
"API_nanoFramework.Device.Bluetooth": "OFF"
"API_nanoFramework.Device.Bluetooth": "OFF",
"API_nanoFramework.Espnow": "ON"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"API_nanoFramework.Espnow": "ON"
"API_nanoFramework.EspNow": "ON"

@@ -387,7 +389,8 @@
"API_nanoFramework.Hardware.Esp32.Rmt": "ON",
"API_System.Device.Dac": "ON",
"API_nanoFramework.Graphics": "OFF",
"API_nanoFramework.Device.Bluetooth": "ON"
"API_nanoFramework.Device.Bluetooth": "ON",
"API_nanoFramework.Espnow": "ON"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"API_nanoFramework.Espnow": "ON"
"API_nanoFramework.EspNow": "ON"

@@ -483,7 +487,7 @@
"API_nanoFramework.Hardware.Esp32.Rmt": "ON",
"API_nanoFramework.Device.Bluetooth": "OFF",
"API_nanoFramework.Graphics": "ON",
"API_Windows.Devices.Adc": "ON",
"API_nanoFramework.Espnow": "ON",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"API_nanoFramework.Espnow": "ON",
"API_nanoFramework.EspNow": "ON",

@@ -0,0 +1,148 @@
//-----------------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with license header.

@@ -0,0 +1,181 @@
//-----------------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with license header.

ret = esp_now_init();
if (ret == ESP_OK)
{

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

ret = esp_now_register_recv_cb(DataRecvCb);
if (ret == ESP_OK)
{

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -0,0 +1,160 @@
//-----------------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with license header.

@josesimoes
Copy link
Member

@SandorDobos also waiting for the PR for the manage library.

@ricavir11
Copy link

I would like to use ESPNOW with nanoframework.
Would be great to have an ETA for this feature !

@josesimoes
Copy link
Member

@SandorDobos any chance we can have this PR moved forward? 😅

@Ellerbach
Copy link
Member

@SandorDobos any help needed to move forward this PR?

@Tollervey
Copy link

Merry Christmas everyone.... Having this in the framework would be very handy indeed.... Cheers

@AdrianSoundy
Copy link
Member

@SandorDobos
Any chance of completing this PR or giving ok for someone else to complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants