(Translated by https://www.hiragana.jp/)
Add Exponential Retry Mechanism with Idempotency Headers · Issue #79 · novuhq/novu-java · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exponential Retry Mechanism with Idempotency Headers #79

Open
5 tasks
Cliftonz opened this issue Oct 6, 2023 · 7 comments
Open
5 tasks

Add Exponential Retry Mechanism with Idempotency Headers #79

Cliftonz opened this issue Oct 6, 2023 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Cliftonz
Copy link
Contributor

Cliftonz commented Oct 6, 2023

In order to enhance the resilience and reliability of our SDK, we would like to introduce an Exponential Retry mechanism for retrying failed requests. Additionally, to ensure the idempotent processing of requests, it's vital to incorporate support for providing an Idempotency Key as per the draft specified in the HTTP Idempotency Key Header Field.

The key requirements for this implementation include:

  1. Exponential Retry Mechanism:

    • The SDK should retry failed requests following an exponential backoff strategy to minimize the contention and impact on the systems involved.
    • The SDK should ensure that the retry mechanism is configurable (e.g., max retries, initial delay, maximum delay).
  2. Idempotency Key Provisioning:

    • The SDK should allow for either automatic or manual provisioning of an Idempotency Key for each request.
    • The Idempotency Key should conform to either CUID, ULID, or UUID formats as specified in the draft.
    • The Idempotency Key should be included in the HTTP Header as Idempotency-Key and following the standards outlined in the draft.
  3. Configuration and Documentation:

    • The SDK should provide configuration options for enabling/disabling the Exponential Retry mechanism and Idempotency Key provisioning.
    • Comprehensive documentation should be provided explaining the configuration options, operational behavior, and the benefits of using the Exponential Retry mechanism along with Idempotency Keys.

Acceptance Criteria:

  • Implementation of the Exponential Retry mechanism with configurable parameters.
  • Provisioning of Idempotency Keys, either automatically or manually, conforming to specified formats (CUID, ULID, or UUID).
  • Adequate unit and integration testing to ensure the robustness and reliability of the implemented features.
  • Comprehensive documentation on the usage and configuration of the Exponential Retry mechanism and Idempotency Key provisioning.
  • Adherence to the specifications outlined in the HTTP Idempotency Key Header Field draft.

Update: You can reference the go-lang library to keep the method signature and configuration the same.
novuhq/go-novu#62

Please refer to the draft for further details on the HTTP Idempotency Key Header Field and ensure adherence to the specified standards while implementing this feature in the SDK.

@Cliftonz Cliftonz added enhancement New feature or request help wanted Extra attention is needed labels Oct 6, 2023
@git-ashug
Copy link
Contributor

Hi, please assign this to me.

Also I had below doubts:

  • Will this issue be broken down to smaller issue as we have different apis. (just like we did for refactoring of APIs)
  • Will ask more doubts in discord as I progress on this issue.

@Cliftonz
Copy link
Contributor Author

@git-ashug Hi no as this effects the underlying http request mechanism which is all one issue.
You can see an example how we do this in the go sdk.

Feel free to ask any questions you need to implement this.

@charan2628
Copy link
Contributor

@git-ashug are you still working on this? @Cliftonz Can I work on this?

@git-ashug
Copy link
Contributor

Hello @charan2628 , I have raised a draft PR and asked some questions there to maintainers. If they don't respond, you can take it from here. Also, would be a great help if you too review the PR and let me know what to do next. Thanks!

@charan2628
Copy link
Contributor

@git-ashug In RetryInterceptor response is null in the while condition for starting iteration

@Cliftonz Cliftonz removed their assignment Dec 18, 2023
@git-ashug git-ashug removed their assignment Dec 31, 2023
@git-ashug
Copy link
Contributor

Hi @charan2628 , you can take this task up.

@charan2628
Copy link
Contributor

Thank you @git-ashug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants