Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Let's accept #282 before this one.
This closes #283
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
The
XlaSend
call requiresenvpool
to make a copy of theaction
to preventaction
from being recycled by the XLA runtime beforeenvpool
finishes using it. Originally, I usecudaMemcpy
to make sure the copy is finished synchronously. However, it seems to cause a problem at issue #283.Here I replace the original
cudaMemcpy
call with the async version and an explicitstreamSynchronize
.It is not clear how
cudaMemcpy
in the default stream in a custom call interacts with the stream managed by pjrt. However, from the code here, I can hypothesize that an explicit stream synchronization in the custom call is safe.Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
(required)make lint
(required)make bazel-test
pass. (required)