-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include Title tag too? #78
Comments
@jayenne so, if metatag title is present it should return the metatag title else it should check for the title tag and return? |
Yes, (IMHO*), *I think if a site goes to the trouble of including an meta title in addition to the title tag then I think it would be the meta title they'd rather be used. agree? |
@jayenne feature wise I agree this would be a valuable addition. Although since this package is specific to fetch meta tags. And ideally if the title tag is not present it shouldn't return. People might be using this if tests cases too.. to check if title is present, title is not present. I looked into the PR I would suggest it would be better if we let the consumer know what is happening under the hood, that title is taken if meta title is not there. Also I would suggest if we let consumer decide whether they want title tag or not if meta title is not present. Let me know your opinion. |
Although not technically a meta tag, the title tag would be a handy addition as it is an arbitraty informative label too.
With a tiny addition between the
$metadata
decleration the$tags as $tag
loop to create a$metadata['title']
key val pair, one could add the given title too.By putting it here, should there be a metata tag called
title
too, it would override this value for the preffered one.The text was updated successfully, but these errors were encountered: