(Translated by https://www.hiragana.jp/)
Add Training Code by bgenchel · Pull Request #136 · spotify/basic-pitch · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Training Code #136

Merged
merged 14 commits into from
Aug 16, 2024
Merged

Add Training Code #136

merged 14 commits into from
Aug 16, 2024

Conversation

bgenchel
Copy link
Collaborator

@bgenchel bgenchel commented Aug 13, 2024

Add code for training the model, tested successfully with an RTX A4000 machine.
Screenshot 2024-08-14 at 3 35 33 PM

Copy link
Contributor

@drubinstein drubinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please post a picture of the tensorboard of a successful run?

basic_pitch/callbacks.py Outdated Show resolved Hide resolved
basic_pitch/callbacks.py Outdated Show resolved Hide resolved
basic_pitch/data/tf_example_deserialization.py Outdated Show resolved Hide resolved
basic_pitch/data/tf_example_deserialization.py Outdated Show resolved Hide resolved
basic_pitch/data/tf_example_deserialization.py Outdated Show resolved Hide resolved
tests/test_callbacks.py Show resolved Hide resolved
tests/test_visualize.py Outdated Show resolved Hide resolved
… unused enum for splits, added a test for the visualize callback that doesn't include model fit.
…value checks, remove model train callback test bc basically duplicate with more work.
… a no-sonify argument to main training, and remove seemingly outdated / mismatching original_validation_ds arg from visualization callback and method.
Copy link
Contributor

@drubinstein drubinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment and then I think I'll merge

basic_pitch/constants.py Outdated Show resolved Hide resolved
bgenchel and others added 2 commits August 16, 2024 11:27
Co-authored-by: David Rubinstein <drubinstein@users.noreply.github.com>
@drubinstein drubinstein merged commit 23be163 into main Aug 16, 2024
20 checks passed
@drubinstein drubinstein deleted the bgenchel/add-training-code branch August 16, 2024 15:49
@dkun7944 dkun7944 mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants