-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain HTTPS sites like imgur.com and xkcd.com not working #9
Comments
Works ok when I test it. Do you have Tcl's tls extension properly installed? What version of Tcl and tls do you have? |
eggdrop v1.8.0 tls1.6.7-src.tar.gz http://tls.cvs.sourceforge.net/viewvc/tls/tls/tls.tcl?revision=1.14 source scripts/tls.tcl Just tried Tcl 8.6.5. Same issue. eggdrop v1.8.0 [07:52:52] Connection to https://raw.githubusercontent.com/teeli/urltitle/master/urltitle.tcl failed |
Some HTTPS URLs require TCL TLS version 1.6.4 or newer. See #6 for more information. |
I'm using TLS 1.6.7. . Maybe I'll try downgrading . .. |
Could you try applying this patch and see if it helps with 1.6.7: diff --git urltitle.tcl urltitle.tcl
index 7628c04..03de92b 100644
--- urltitle.tcl
+++ urltitle.tcl
@@ -84,9 +84,6 @@ namespace eval UrlTitle {
if {[package vcompare $tlsVersion 1.7.11] >= 0} {
# tls version 1.7.11 should support autoservername
::tls::socket -autoservername true {*}$opts $host $port
- } elseif {[package vcompare $tlsVersion 1.6.7] >= 0} {
- # From version 1.6.7, it shouldn't be necessary to specify any ciphers.
- ::tls::socket -servername $host {*}$opts $host $port
} elseif {[package vcompare $tlsVersion 1.6.4] >= 0} {
::tls::socket -ssl3 false -ssl2 false -tls1 true -servername $host {*}$opts $host $port
} else { |
Wow, that fixed it! Nice man. imgur.com and xkcd.com both work now. |
Thanks for reporting. I'll update the script and push the change. |
Do you also need to load json.tcl for this? Aren't there going to be any instructions for HTTPS url-titling setup? |
Certain HTTPS sites like imgur.com and xkcd.com not working.
example:
Connection to https://imgur.com/gallery/jZCWbFf failed
not sure if its my eggdrop setup, or the urltitle script
The text was updated successfully, but these errors were encountered: