⚓ T246493 [EPIC] Deploy NearbyPages everywhere

Subject	Repo	Branch	Lines +/-
Enable Nearby everywhere	operations/mediawiki-config	master	+1 -4
Enable Nearby on Hebrew and French Wikipedia	operations/mediawiki-config	master	+2 -0
Enable Extension:Nearby on wikidata	operations/mediawiki-config	master	+1 -0
Enable NearbyPages on beta cluster	operations/mediawiki-config	master	+31 -0
Start branching NearbyPages extension	mediawiki/tools/release	master	+1 -0

Status	Subtype	Assigned	Task
Resolved		None	T246493 [EPIC] Deploy NearbyPages everywhere
Resolved		Jdlrobson	T246494 Drop Nearby code from MobileFrontend
Resolved		Jdlrobson	T246495 [EPIC] Build a new version of Special:Nearby using Vue framework
Resolved		None	T246500 Request geolocation from user
Resolved		None	T246503 Build the Card and PageList component in Vue
Resolved		None	T246505 Create the API component
Resolved		Jdlrobson	T246532 Localize Special:Nearby on trwiki
Resolved		None	T252263 Add tests for JS code
Resolved		Kizule	T246527 Enable phan and seccheck
Resolved		Kizule	T246528 Enable PHPCS
Resolved	Security	Jdlrobson	T269291 Security Readiness Review For Extension:NearbyPages
Resolved		Jdlrobson	T289738 Performance review of Extension:NearbyPages
Resolved		mmartorana	T302772 Application Security Review Request : Codex
Resolved		None	T300588 NearbyPages skeleton cards generate a broken link
Resolved	BUG REPORT	None	T300593 Titles returned by geosearch are non canonical
Open	BUG REPORT	None	T300594 Can't go back from starting URL containing hash fragment
Resolved		AnneT	T278311 Add Card component to Codex
Resolved	Spike	• DAbad	T310189 [SPIKE] Create scope for Card MVP
Resolved		• DAbad	T310628 Design and build initial Card component (MVP)
Resolved		• EUdoh-WMF	T310634 Create a standalone Thumbnail component
Open		None	T312580 [Needs discussion] Thumbnail should be resizeable
Open		None	T315557 Add configurable Thumbnail demo
Open		None	T313214 Thumbnail: Replace default placeholder icon
Resolved		Volker_E	T312582 Thumbnail: Thumbnails should have relative sizes

Jdlrobson changed the status of subtask T246494: Drop Nearby code from MobileFrontend from Open to Stalled.Feb 28 2020, 9:23 PM

Jdlrobson updated the task description. (Show Details)

Ammarpad mentioned this in T246532: Localize Special:Nearby on trwiki.Feb 29 2020, 1:58 PM

Reedy closed subtask T246527: Enable phan and seccheck as Resolved.Feb 29 2020, 2:52 PM

Reedy closed subtask T246528: Enable PHPCS as Resolved.

Jdlrobson moved this task from Backlog to Todo on the NearbyPages board.Apr 9 2020, 8:59 PM

Jdlrobson closed subtask T246495: [EPIC] Build a new version of Special:Nearby using Vue framework as Resolved.Jul 2 2020, 2:14 AM

Jdlrobson updated the task description. (Show Details)Dec 2 2020, 8:21 PM

sbassett changed the status of subtask T269291: Security Readiness Review For Extension:NearbyPages from Open to Stalled.Dec 7 2020, 4:36 PM

sbassett changed the status of subtask T269291: Security Readiness Review For Extension:NearbyPages from Stalled to Open.Dec 7 2020, 4:56 PM

Heyo! Quick question, @Jdlrobson: which team will be the steward of this new extension? Thanks!

@greg - readers web (we are just breaking out this functionality from MobileFrontend in a more maintainable form)

Jdlrobson added projects: Goal, Web-Team-Backlog.Aug 3 2021, 5:56 PM

Jdlrobson moved this task from Incoming to unsed on the Web-Team-Backlog board.

Zabe subscribed.Aug 4 2021, 3:27 PM

Jdlrobson moved this task from unsed to Needs Prioritization (Tech) on the Web-Team-Backlog board.Aug 10 2021, 8:50 PM

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.

Jdlrobson moved this task from Backlog to WVUI migrations on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Aug 11 2021, 6:05 PM

sbassett closed subtask T269291: Security Readiness Review For Extension:NearbyPages as Resolved.Aug 16 2021, 6:47 PM

Change 713653 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable NearbyPages on beta cluster

https://gerrit.wikimedia.org/r/713653

gerritbot added a project: Patch-For-Review.Aug 18 2021, 4:24 PM

Change 713667 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/tools/release@master] Start branching NearbyPages extension

https://gerrit.wikimedia.org/r/713667

Change 713667 merged by jenkins-bot:

[mediawiki/tools/release@master] Start branching NearbyPages extension

https://gerrit.wikimedia.org/r/713667

Heyo again, @Jdlrobson ! I don't see a mention of a performance review in the task description; is one planned for this? I just want to make sure that it's planned/accounted for appropriately by the Perf team. Thanks!

Jdlrobson updated the task description. (Show Details)Aug 24 2021, 8:24 PM

Jdlrobson added a subtask: T289738: Performance review of Extension:NearbyPages.Aug 25 2021, 8:47 PM

Change 713653 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable NearbyPages on beta cluster

https://gerrit.wikimedia.org/r/713653

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:17:30Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 1/3) (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:18:50Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 2/3) (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:20:07Z] <urbanecm@deploy1002> Synchronized wmf-config/extension-list: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 3/3) (duration: 01m 05s)

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2021, 12:10 AM

Jdlrobson updated the task description. (Show Details)Sep 2 2021, 12:49 AM

@Ladsgroup the new NearbyPages is at https://wikidata.beta.wmflabs.org/wiki/Special:Nearby
Who on Wikidata.org side would be able to review it and approve it from a product perspective for deployment?

The new version is built with Vue.js/WVUI and should fix various problems with the old implementation.

In T246493#7329778, @Jdlrobson wrote:

@Ladsgroup the new NearbyPages is at https://wikidata.beta.wmflabs.org/wiki/Special:Nearby

Looks awesome. cc. @Addshore

Who on Wikidata.org side would be able to review it and approve it from a product perspective for deployment?

That'd be @Lydia_Pintscher and @Manuel

The new version is built with Vue.js/WVUI and should fix various problems with the old implementation.

I had a quick look and it looks really nice!
One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata. It should be Items. Is this something that can be configured or gotten from an existing place?

One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata.

We could call these "items" by adding translations to WikimediaMessages but pages is probably more generic than articles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/719352)

In T246493#7337693, @Jdlrobson wrote:

One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata.

We could call these "items" by adding translations to WikimediaMessages but pages is probably more generic than articles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/719352)

I suggest avoiding more strings for translations. Adding translation messages adds a lot of burden to volunteer translators (as a person who does a lot for Persian, it's tedious, boring, thankless and annoying).

Also this feature (could) possibly be deployed outside of WMF in a Wikibase repo.

To clarify, I suggest changing "article" to "page" and not adding another message in WikimediaMessages

I'm fine with pages as well yeah.

Jdlrobson mentioned this in T117159: uselang parameter doesn't work for labels/descriptions on Special:Nearby.Sep 21 2021, 8:32 PM

Jdlrobson updated the task description. (Show Details)Sep 22 2021, 9:10 PM

Jdlrobson moved this task from WVUI migrations to MobileFrontend frontend cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Nov 1 2021, 10:29 PM

Jdlrobson moved this task from MobileFrontend frontend cleanup to Remove mobile Watchlist special page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Nov 29 2021, 11:02 PM

Jdlrobson moved this task from Remove mobile Watchlist special page to WVUI migrations on the Web-Team-Backlog (Needs Prioritization (Tech)) board.

In T246493#7337723, @Ladsgroup wrote:

To clarify, I suggest changing "article" to "page" and not adding another message in WikimediaMessages

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/719352
I don't think there's a better word that applies to all projects than "pages".

I just wanted to point out for Wikidata that WikimediaMessages option (or on-wiki override in MediaWiki namespace) is available if "pages" makes less sense than "items" but as you've pointed out that comes with trade offs.

Jdlrobson moved this task from WVUI migrations to Codex focus on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Feb 1 2022, 4:23 PM

Jdlrobson updated the task description. (Show Details)Feb 1 2022, 11:26 PM

Jdlrobson closed subtask T289738: Performance review of Extension:NearbyPages as Resolved.Feb 17 2022, 8:42 PM

Jdlrobson added a subtask: T302772: Application Security Review Request : Codex.Mar 9 2022, 7:24 PM

Jdlrobson added subtasks: T300588: NearbyPages skeleton cards generate a broken link, T300593: Titles returned by geosearch are non canonical.

Jdlrobson added a subtask: T300594: Can't go back from starting URL containing hash fragment.

Jdlrobson added a subtask: T256036: Add Card component to Codex.Mar 10 2022, 1:01 AM

Tacsipacsi subscribed.Mar 15 2022, 8:52 PM

• STH changed the status of subtask T256036: Add Card component to Codex from Open to Stalled.May 26 2022, 12:28 AM

AnneT reopened subtask T256036: Add Card component to Codex as Open.May 31 2022, 5:28 PM

Catrope edited subtasks, added: T278311: Add Card component to Codex; removed: T256036: Add Card component to Codex.Jun 9 2022, 12:53 AM

mmartorana changed the status of subtask T302772: Application Security Review Request : Codex from Open to In Progress.Jun 28 2022, 5:45 PM

• DAbad changed the status of subtask T278311: Add Card component to Codex from Open to In Progress.Jun 30 2022, 4:26 PM

Catrope closed subtask T302772: Application Security Review Request : Codex as Resolved.Jul 19 2022, 9:55 PM

Jdlrobson closed subtask T300588: NearbyPages skeleton cards generate a broken link as Resolved.Aug 30 2022, 4:45 PM

Jdlrobson closed subtask T300593: Titles returned by geosearch are non canonical as Resolved.

Change 830313 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable Extension:Nearby on wikidata

https://gerrit.wikimedia.org/r/830313

gerritbot added a project: Patch-For-Review.Sep 7 2022, 1:24 AM

Jdlrobson updated the task description. (Show Details)Sep 7 2022, 8:46 PM

Change 830313 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Extension:Nearby on wikidata

https://gerrit.wikimedia.org/r/830313

Mentioned in SAL (#wikimedia-operations) [2022-09-07T20:50:47Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:830313|Enable Extension:Nearby on wikidata (T246493)]]

Mentioned in SAL (#wikimedia-operations) [2022-09-07T20:51:11Z] <samtar@deploy1002> samtar and jdlrobson: Backport for [[gerrit:830313|Enable Extension:Nearby on wikidata (T246493)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-09-07T20:56:42Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:830313|Enable Extension:Nearby on wikidata (T246493)]] (duration: 05m 54s)

Jdlrobson updated the task description. (Show Details)Sep 9 2022, 3:43 PM

Change 831117 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable Nearby on Hebrew and French Wikipedia

https://gerrit.wikimedia.org/r/831117

Jdlrobson mentioned this in T301745: [TECHNICAL GOAL] Prepare Codex and Nearby for deployment.Sep 12 2022, 7:25 PM

Change 831117 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Nearby on Hebrew and French Wikipedia

https://gerrit.wikimedia.org/r/831117

Mentioned in SAL (#wikimedia-operations) [2022-09-12T20:42:19Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:831117|Enable Nearby on Hebrew and French Wikipedia (T246493)]]

Mentioned in SAL (#wikimedia-operations) [2022-09-12T20:42:38Z] <samtar@deploy1002> samtar and jdlrobson: Backport for [[gerrit:831117|Enable Nearby on Hebrew and French Wikipedia (T246493)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-09-12T20:49:46Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:831117|Enable Nearby on Hebrew and French Wikipedia (T246493)]] (duration: 07m 27s)

Jdlrobson updated the task description. (Show Details)Sep 12 2022, 8:52 PM

Change 833435 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable Nearby everywhere

https://gerrit.wikimedia.org/r/833435

Change 833435 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Nearby everywhere

https://gerrit.wikimedia.org/r/833435

Mentioned in SAL (#wikimedia-operations) [2022-09-20T20:04:38Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:833435|Enable Nearby everywhere (T246493)]]

Mentioned in SAL (#wikimedia-operations) [2022-09-20T20:05:03Z] <cjming@deploy1002> cjming and jdlrobson: Backport for [[gerrit:833435|Enable Nearby everywhere (T246493)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-09-20T20:13:40Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:833435|Enable Nearby everywhere (T246493)]] (duration: 09m 02s)

Zabe mentioned this in T318192: "Nearby" link visible in all projects.Sep 20 2022, 8:29 PM

Jdlrobson updated the task description. (Show Details)Sep 21 2022, 5:23 PM