(Translated by https://www.hiragana.jp/)
⚓ T299663 Remove different modes from LanguageFallbackChainFactory
Page MenuHomePhabricator
Create Task
Maniphest T299663

Remove different modes from LanguageFallbackChainFactory
Closed, ResolvedPublic
Actions

Description

LanguageFallbackChainFactory can create fallback chains from languages in several modes (FALLBACK_SELF, FALLBACK_VARIANTS, and FALLBACK_OTHERS), but no caller uses this ability – I think the last uses were removed in 2016 (Use FALLBACK_ALL for all data access functionality, T76218). Since this complicates the code, and we now need to touch it for the mul language code (does that count as FALLBACK_OTHERS or should it be a new mode?), let’s get rid of this ability.

Details

SubjectRepoBranchLines +/-
Simplify LanguageFallbackChainFactory implementationmediawiki/extensions/Wikibasemaster+95 -112
Don’t use custom fallback mode in TermLanguageFallbackChainTestmediawiki/extensions/Wikibasemaster+31 -56
Remove mode arguments from LanguageFallbackChainFactorymediawiki/extensions/Wikibasemaster+53 -157
Remove custom mode from EntityAccessorTestmediawiki/extensions/Wikibasemaster+1 -3
Fix type comments in LanguageFallbackChainFactorymediawiki/extensions/Wikibasemaster+3 -2
Remove LanguageFallbackChainFactory default mode argumentsmediawiki/extensions/Wikibasemaster+10 -21
Remove custom mode from LanguageFallbackLabelDescriptionLookupFactorymediawiki/extensions/Wikibasemaster+2 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 20 2022, 4:42 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Doing on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.
gerritbot added a comment.Jan 20 2022, 4:50 PM

Change 755730 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove custom mode from LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/755730

gerritbot added a project: Patch-For-Review.Jan 20 2022, 4:50 PM
gerritbot added a comment.Jan 20 2022, 5:00 PM

Change 755732 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove LanguageFallbackChainFactory default mode arguments

https://gerrit.wikimedia.org/r/755732

gerritbot added a comment.Jan 20 2022, 5:06 PM

Change 755733 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove custom mode from EntityAccessorTest

https://gerrit.wikimedia.org/r/755733

Lucas_Werkmeister_WMDE added a comment.Jan 20 2022, 5:16 PM

Hm, I just noticed the way the mode is used in buildFromBabel()… I think the changes I uploaded so far (above) are still nice cleanups, but I’m not sure if this task can be completed as I originally imagined it.

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Jan 20 2022, 5:16 PM
gerritbot added a comment.Jan 21 2022, 11:12 AM

Change 755953 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix type comments in LanguageFallbackChainFactory

https://gerrit.wikimedia.org/r/755953

gerritbot added a comment.Jan 21 2022, 2:58 PM

Change 756008 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Don\u2019t use custom fallback mode in TermLanguageFallbackChainTest

https://gerrit.wikimedia.org/r/756008

gerritbot added a comment.Jan 21 2022, 3:51 PM

Change 756015 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove mode arguments from LanguageFallbackChainFactory

https://gerrit.wikimedia.org/r/756015

gerritbot added a comment.Jan 21 2022, 5:36 PM

Change 756032 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Simplify LanguageFallbackChainFactory implementation

https://gerrit.wikimedia.org/r/756032

gerritbot added a comment.Jan 25 2022, 12:38 AM

Change 755730 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove custom mode from LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/755730

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 25 2022, 1:00 AM
gerritbot added a comment.Jan 25 2022, 10:38 AM

Change 755732 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove LanguageFallbackChainFactory default mode arguments

https://gerrit.wikimedia.org/r/755732

gerritbot added a comment.Jan 25 2022, 10:39 AM

Change 755733 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove custom mode from EntityAccessorTest

https://gerrit.wikimedia.org/r/755733

gerritbot added a comment.Jan 25 2022, 10:39 AM

Change 755953 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix type comments in LanguageFallbackChainFactory

https://gerrit.wikimedia.org/r/755953

gerritbot added a comment.Jan 25 2022, 10:39 AM

Change 756008 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Don\u2019t use custom fallback mode in TermLanguageFallbackChainTest

https://gerrit.wikimedia.org/r/756008

gerritbot added a comment.Jan 25 2022, 10:39 AM

Change 756015 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove mode arguments from LanguageFallbackChainFactory

https://gerrit.wikimedia.org/r/756015

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.20; 2022-01-31); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 25 2022, 11:00 AM
gerritbot added a comment.Jan 31 2022, 11:42 PM

Change 756032 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Simplify LanguageFallbackChainFactory implementation

https://gerrit.wikimedia.org/r/756032

hoo moved this task from Peer Review to Tech Verification on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Feb 1 2022, 2:09 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 1 2022, 4:10 PM
Lucas_Werkmeister_WMDE moved this task from Tech Verification to Our work done on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.
Manuel mentioned this in T312097: [EPIC] MUL - Default values for labels and aliases .Jul 5 2022, 1:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits