(Translated by https://www.hiragana.jp/)
⚓ T303207 Make dlocal default for PE UY
Page MenuHomePhabricator
Create Task
Maniphest T303207

Make dlocal default for PE UY
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

RE T208963

When testing is done, these countries should have dlocal set as default.

Details

SubjectRepoBranchLines +/-
Set AstroPay as default gateway for PE and UYmediawiki/extensions/DonationInterfacemaster+4 -4
Fix PE form settingsmediawiki/extensions/DonationInterfacemaster+1 -1
Ensure PE/UY Dlocal forms are not chosen by defaultmediawiki/extensions/DonationInterfacemaster+2 -2
Uncomment PE + UY form settingsmediawiki/extensions/DonationInterfacemaster+3 -4
Customize query in gerrit

Related Objects

Event Timeline

• DStrine created this task.Mar 7 2022, 6:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2022, 6:28 PM
• DStrine mentioned this in T208963: Switch PE and UY to dlocal for processing.Mar 7 2022, 6:28 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.
gerritbot added a comment.Mar 7 2022, 6:29 PM

Change 759003 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Uncomment PE + UY form settings

https://gerrit.wikimedia.org/r/759003

gerritbot added a project: Patch-For-Review.Mar 7 2022, 6:29 PM
gerritbot added a comment.Mar 7 2022, 6:33 PM

Change 759003 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Uncomment PE + UY form settings

https://gerrit.wikimedia.org/r/759003

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2022, 7:10 PM
Dwisehaupt set the point value for this task to 2.Mar 7 2022, 9:15 PM
gerritbot added a comment.Mar 7 2022, 10:16 PM

Change 768815 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Ensure PE/UY Dlocal forms are not chosen by default

https://gerrit.wikimedia.org/r/768815

gerritbot added a project: Patch-For-Review.Mar 7 2022, 10:16 PM
gerritbot added a comment.Mar 8 2022, 6:16 AM

Change 768815 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Ensure PE/UY Dlocal forms are not chosen by default

https://gerrit.wikimedia.org/r/768815

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 8 2022, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 8 2022, 7:10 AM
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Mar 8 2022, 8:24 PM
• DStrine moved this task from Current Sprint to Sprint +1 on the Fundraising-Backlog board.
• DStrine moved this task from Sprint +1 to Next on the Fundraising-Backlog board.Mar 13 2022, 6:29 PM
• DStrine added a subscriber: EMartin.Mar 24 2022, 5:13 PM

@EMartin FYI default is ingenico right now until the 1 hour test and a conversation.

• DStrine mentioned this in T293508: Enable South Africa through Dlocal.Mar 24 2022, 5:13 PM
• DStrine added a subscriber: HNordeenWMF.Mar 31 2022, 5:35 PM
• DStrine added a comment.Apr 25 2022, 6:47 PM

Just to cross link all tasks, this is the corresponding payments task https://app.asana.com/0/1200599190639529/1199928025421117/f

From what I understand we are approaching the 1 hour test for these. @HNordeenWMF is able to set up banners with dlocal hard coded. If the 1 hour test is good and we are feel comfortable, we can make these default.

EMartin added a comment.Apr 25 2022, 7:04 PM

yes, we have tested some time ago and feel comfortable for the external test. Please make it default for the test.

• DStrine added a subscriber: • TSkaff.Apr 25 2022, 7:34 PM

We can't make it default for the test. @HNordeenWMF, @TSkaff and banner team can hard code it into banners for the 1 hour test. Once that is done and things look good, we can turn it on as the default for PE and UY.

EMartin added a comment.Apr 25 2022, 7:37 PM

Great, we'll leave this with the Banner team to indicate making it the default post test. Is that who owns that part of the process? @TSkaff @DStrine

HNordeenWMF added a subscriber: Pcoombe.Apr 25 2022, 9:50 PM

I'm running into the problem that when I hardcode a Latin America banner for Astropay, it doesn't go to dLocal for Peru.
https://es.wikipedia.org/w/index.php?title=NASA&banner=B2122_0511_esLA_dsk_p1_lg_twin1&country=PE

Uruguay is working (https://es.wikipedia.org/w/index.php?title=NASA&banner=B2122_0511_esLA_dsk_p1_lg_twin1&country=UY)

@Pcoombe might you know how to help?

• DStrine added a subscriber: Ejegg.Apr 25 2022, 9:54 PM

@Ejegg as well if that helps

gerritbot added a comment.Apr 25 2022, 10:33 PM

Change 785946 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Fix PE form settings

https://gerrit.wikimedia.org/r/785946

gerritbot added a project: Patch-For-Review.Apr 25 2022, 10:33 PM
Ejegg added a comment.Apr 25 2022, 10:36 PM

Hi @HNordeenWMF, I just found the problem - the PE form definition was drafted a while ago when we were still using the old 'whitelist' terminology. We did an update to the rest of the definitions to remove that terminology, but then later approved the draft of the PE form definition without updating it to match.

The fix is ready for fr-tech to review and deploy.

Pcoombe mentioned this in T306356: LATAM donors receiving esES thank you email instead of esMX.Apr 27 2022, 10:14 AM
gerritbot added a comment.Apr 28 2022, 3:26 PM

Change 785946 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Fix PE form settings

https://gerrit.wikimedia.org/r/785946

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2022, 3:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 28 2022, 4:00 PM
Ejegg added a comment.Apr 28 2022, 6:07 PM

@HNordeenWMF we just deployed that typo fix. That PE banner you linked now successfully routes donors to the DLocal form.

HNordeenWMF added a comment.Apr 28 2022, 6:31 PM

great, thank you @Ejegg !

• DStrine moved this task from Next to Triage on the Fundraising-Backlog board.May 17 2022, 6:10 PM
• DStrine added a project: Fundraising Sprint Incantation optimisation.May 17 2022, 7:40 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
gerritbot added a comment.May 17 2022, 10:03 PM

Change 792730 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Set AstroPay as default gateway for PE and UY

https://gerrit.wikimedia.org/r/792730

gerritbot added a project: Patch-For-Review.May 17 2022, 10:03 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Incantation optimisation board.May 17 2022, 10:04 PM
gerritbot added a comment.May 17 2022, 10:12 PM

Change 792730 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Set AstroPay as default gateway for PE and UY

https://gerrit.wikimedia.org/r/792730

AnnWF moved this task from Review to Pending Deployment on the Fundraising Sprint Incantation optimisation board.May 17 2022, 10:24 PM
Maintenance_bot removed a project: Patch-For-Review.May 17 2022, 10:30 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).May 18 2022, 3:00 AM
• DStrine triaged this task as High priority.May 18 2022, 4:18 PM
Ejegg added a comment.May 18 2022, 4:40 PM

This is merged and ready to deploy as soon as the deployment script is working again

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Incantation optimisation board.May 19 2022, 12:34 AM
Ejegg added a comment.May 19 2022, 1:13 AM

OK, default has been changed.

XenoRyet closed this task as Resolved.May 24 2022, 7:15 PM
XenoRyet set Final Story Points to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits