(Translated by https://www.hiragana.jp/)
⚓ T306705 Images are no longer displayed on mobile edit preview
Page MenuHomePhabricator
Create Task
Maniphest T306705

Images are no longer displayed on mobile edit preview
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
• Esanders
Authored By
matej_suchanek
Apr 22 2022, 10:33 AM
Tags
Referenced Files
F35092353: IMG_4988.PNG
May 2 2022, 8:21 PM
F35092356: IMG_4987.PNG
May 2 2022, 8:21 PM
F35062817: obrazek.png
Apr 22 2022, 10:33 AM
Subscribers
Aklapper
EAkinloose
• Esanders
Jdlrobson
matej_suchanek
matmarex
• Peter
View All 9 Subscribers

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The images in the gallery are not displayed, there are just grey rectangles. Might be an issue with lazy loading.

What should have happened instead?:
The images in the gallery are displayed.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

obrazek.png (579×1 px, 51 KB)

MediaWiki: 1.39.0-wmf.8 (a4aaf3c)
MobileFrontend: 2.4.0 (875c136)

Was reproduced using:

  • Android 10 (Nokia 7 plus), Google Chrome 100 or Opera 62.5.2254.61243
  • Windows 10, Firefox 99.0.1

Details

SubjectRepoBranchLines +/-
lazyLoadedImages: Run on wikipage.content hookmediawiki/extensions/MobileFrontendmaster+10 -5
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Apr 22 2022, 10:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2022, 10:33 AM
Jdlrobson edited projects, added Editing-team, Web-Team-Backlog, Regression, MobileFrontend (MobileFrontend (Editor)); removed MobileFrontend.Apr 25 2022, 2:16 PM
Jdlrobson added subscribers: • Esanders, Jdlrobson.

@Esanders this is a new regression related to the recent changes to run the mobile formatter on edit previews (T248493). I think you need to modify the logic in ExtMobileFrontend::domParseMobile. Let me know if you need any help.

Jdlrobson renamed this task from Images in gallery not displayed on mobile edit preview to Images are no longer displayed on mobile edit preview.Apr 25 2022, 3:57 PM
Jdlrobson mentioned this in T301578: Comments containing navbox partially removed by MobileFormatter.
• Esanders added a comment.Apr 25 2022, 4:18 PM

The HTML looks the same. Is this not just a case of the lazyLoadedImages JS not running?

ovasileva moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Apr 25 2022, 4:23 PM
gerritbot added a comment.Apr 25 2022, 4:29 PM

Change 785884 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] lazyLoadedImages: Run on wikipage.content hook

https://gerrit.wikimedia.org/r/785884

gerritbot added a project: Patch-For-Review.Apr 25 2022, 4:29 PM
• Esanders claimed this task.Apr 25 2022, 4:29 PM
• Esanders edited projects, added Editing-team (Kanban Board); removed Editing-team.
• Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex subscribed.Apr 26 2022, 9:43 PM
In T306705#7876967, @Jdlrobson wrote:

@Esanders this is a new regression related to the recent changes to run the mobile formatter on edit previews (T248493). I think you need to modify the logic in ExtMobileFrontend::domParseMobile. Let me know if you need any help.

For future reference, this was actually caused by this change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/763622 for task T219420. Prior to our changes, the images were not using lazy loading in preview (they were always immediately loaded).

matmarex mentioned this in T219420: Update page dynamically after save on mobile.Apr 26 2022, 9:45 PM
gerritbot added a comment.Apr 28 2022, 5:11 PM

Change 785884 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] lazyLoadedImages: Run on wikipage.content hook

https://gerrit.wikimedia.org/r/785884

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2022, 5:31 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.May 2 2022, 5:29 PM
DLynch added a project: Editing QA.
EAkinloose subscribed.May 2 2022, 8:21 PM

Images are displayed as expected.

For relatable visuals, I tested (on https://cs.m.wikipedia.beta.wmflabs.org/) content from https://cs.m.wikipedia.org/wiki/Severomariansk%C3%A1_vlajka as well.

After fix:

IMG_4987.PNG (2×1 px, 763 KB)

Before fix:

IMG_4988.PNG (2×1 px, 318 KB)

EAkinloose edited projects, added Verified; removed Editing QA.May 2 2022, 8:21 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg moved this task from Inbox to High Priority on the Editing QA board.May 2 2022, 10:25 PM
ppelberg added a project: Editing QA.
ovasileva moved this task from Not ready to estimate to Tracking on the Web-Team-Backlog board.May 3 2022, 1:13 PM
Ryasmeen moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.May 4 2022, 9:29 PM
Ryasmeen added subscribers: • Peter, Ryasmeen.

Hey @Peter: It seems like this issue has once been verified by QA, but it got moved back to Editing QA workboard again. Has there been more work/changes around this task? If so, could you please add the details on the task, so we can work on it again.

ppelberg closed this task as Resolved.May 5 2022, 4:32 PM
ppelberg subscribed.
In T306705#7905127, @Ryasmeen wrote:

Hey @Peter: It seems like this issue has once been verified by QA, but it got moved back to Editing QA workboard again. Has there been more work/changes around this task? If so, could you please add the details on the task, so we can work on it again.

Eeek.

This was a mistake on my end. I do not see any more work as needing to be done on this. Resolving!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 5 2022, 4:32 PM
Jdrewniak mentioned this in T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().Apr 2 2024, 6:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits