| KStoller-WMF | |
| Dec 15 2022, 7:52 PM |
| F36318393: Screen Shot 2023-01-18 at 3.10.16 PM.png | |
| Jan 18 2023, 11:11 PM |
| F36318391: Screen Shot 2023-01-18 at 3.09.40 PM.png | |
| Jan 18 2023, 11:11 PM |
| F36117417: image.png | |
| Jan 11 2023, 1:40 PM |
| F35868719: Screen Shot 2022-12-15 at 11.42.09 AM.png | |
| Dec 15 2022, 7:52 PM |
| F35868713: Screen Shot 2022-12-15 at 11.39.26 AM.png | |
| Dec 15 2022, 7:52 PM |
| F35868708: Screen Shot 2022-12-15 at 11.37.02 AM.png | |
| Dec 15 2022, 7:52 PM |
Description
Follow up task from T310661 design review.
Current Impact Module screenshot  | Figma Design  |
Current Homepage screenshot:
Fix the alignment of the "i" icon with the label (expect to be vertically centered but the screenshot seems to show top-aligned), and similarly the vertically centre alignment of scorecard icons with the value:
Acceptance Criteria
Given I'm viewing the new impact module,
Then the "i" icon should be vertically centered as shown in designs
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| User impact: fix vertical alignment of scorecards texts and icons | mediawiki/extensions/GrowthExperiments | master | +172 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | KStoller-WMF | T248330 [EPIC] Growth: Positive reinforcement | |||
| Resolved | KStoller-WMF | T222310 [EPIC] Positive reinforcement: New Impact Module | |||
| Resolved | Sgs | T325325 Impact Module: "i" icon alignment |
I just realized that there is another task in with the info icon in being discussed:
https://phabricator.wikimedia.org/T310665#8470610
Should we merge these?
Change 868650 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: fix vertical alignment of scorecards texts and icons
I think this is a separate issue. T310665 comments are around if we should use Codex or OOUI icons and what's the expectation for the info icon on arwiki.
@RHo @KStoller-WMF that's a question for you, my comment in Gerrit was:
the location of the "(i)" icon all the way across from the text in the scorecard seems confusing; would it be more standard if it was directly to the left of the label that says what the scorecard is about? e.g. "(i) Longest streak". Or directly to the right: "Longest streak (i)"
But if we want to change that, let's do it in a separate task.
Let's keep it in the current position as it is meant to be info for the entire scorecard, similar to how the info icon is per row in the Notifications section of Special:Preferences:
Change 868650 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] User impact: fix vertical alignment of scorecards texts and icons
